chrome/browser/ui/views/tabs/tab_strip.h - Issue 598013003: Added views::ViewModelT<T>, a type-safe template version of ViewModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 598013003: Added views::ViewModelT<T>, a type-safe template version of ViewModel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appsgridview-static-casts

Patch Set: DISALLOW_COPY_AND_ASSIGN. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/stacked_tab_strip_layout.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc » ('j') | ui/views/view_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_strip.h

diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h

index 34cc81004881c1a3c6a2ea5f8b30ce455ca94e34..f4fb10d1176a013e66148a5ae5acd6318219d629 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.h

+++ b/chrome/browser/ui/views/tabs/tab_strip.h

@@ -150,7 +150,7 @@ class TabStrip : public views::View,

// Returns the Tab at |index|.

Tab* tab_at(int index) const {

- return static_cast<Tab*>(tabs_.view_at(index));

+ return tabs_.view_at(index);

}

// Returns the index of the specified tab in the model coordinate system, or

@@ -596,7 +596,7 @@ class TabStrip : public views::View,

// |tabs_closing_map_|. When the animation completes the tab is removed from

// |tabs_closing_map_|. The painting code ensures both sets of tabs are

// painted, and the event handling code ensures only tabs in |tabs_| are used.

- views::ViewModel tabs_;

+ views::ViewModel<Tab> tabs_;

TabsClosingMap tabs_closing_map_;

scoped_ptr<TabStripController> controller_;