Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 598013002: Let toParentMediaElement return null for the media element itself (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/video-webkit-appearance-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControlElementTypes.cpp
diff --git a/Source/core/html/shadow/MediaControlElementTypes.cpp b/Source/core/html/shadow/MediaControlElementTypes.cpp
index 9094ed82328d9d9ce2930a26102cd73f13f729a9..78f1a2cfd8c19ea043dfa676866150ac7adcefb5 100644
--- a/Source/core/html/shadow/MediaControlElementTypes.cpp
+++ b/Source/core/html/shadow/MediaControlElementTypes.cpp
@@ -51,7 +51,7 @@ HTMLMediaElement* toParentMediaElement(Node* node)
return 0;
Node* mediaNode = node->shadowHost();
if (!mediaNode)
- mediaNode = node;
+ return 0;
fs 2014/09/24 15:48:16 paintMediaSliderThumb and paintMediaVolumeSliderTh
philipj_slow 2014/09/25 07:53:10 They pass renderer->node()->shadowHost() because t
fs 2014/09/25 09:30:19 Ok, I figured it'd be something like that. LGTM.
if (!isHTMLMediaElement(mediaNode))
return 0;
« no previous file with comments | « LayoutTests/media/video-webkit-appearance-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698