Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 598003002: Fix js style issues. (Closed)

Created:
6 years, 3 months ago by Peter Lundblad
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Fix js style issues in a ChromeVox module. BUG=394284 Committed: https://crrev.com/286bc316b7857ca48688b033f854379013514548 Cr-Commit-Position: refs/heads/master@{#296955}

Patch Set 1 #

Patch Set 2 : Fix js issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/braille_table.js View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598003002/20001
6 years, 3 months ago (2014-09-24 14:32:57 UTC) #2
Peter Lundblad
6 years, 3 months ago (2014-09-24 14:34:38 UTC) #5
Peter Lundblad
Friendly ping.
6 years, 2 months ago (2014-09-26 09:02:24 UTC) #6
dmazzoni
lgtm
6 years, 2 months ago (2014-09-26 16:03:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598003002/20001
6 years, 2 months ago (2014-09-26 16:04:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0c073a4e2c445066cde9555842df94b0bc8027e9
6 years, 2 months ago (2014-09-26 16:08:17 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 16:08:54 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/286bc316b7857ca48688b033f854379013514548
Cr-Commit-Position: refs/heads/master@{#296955}

Powered by Google App Engine
This is Rietveld 408576698