Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 597993003: ninja win: Add support for 'CallingConvention' (Closed)

Created:
6 years, 3 months ago by Shezan Baig (Bloomberg)
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja win: Add support for 'CallingConvention' Each calling convention decorates C functions in a different way, so we can use that to test the flag. BUG= R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1984

Patch Set 1 #

Patch Set 2 : fix MSVSSettings_test range for CallingConvention #

Patch Set 3 : Remove /Gv, fix comments in def file #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + test/win/compiler-flags/calling-convention.cc View 1 chunk +1 line, -2 lines 0 comments Download
A test/win/compiler-flags/calling-convention.gyp View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A + test/win/compiler-flags/calling-convention-cdecl.def View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
A + test/win/compiler-flags/calling-convention-fastcall.def View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
A + test/win/compiler-flags/calling-convention-stdcall.def View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
A + test/win/gyptest-cl-calling-convention.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Shezan Baig (Bloomberg)
6 years, 3 months ago (2014-09-24 15:42:13 UTC) #2
scottmg
Nice test! LGTM.
6 years, 3 months ago (2014-09-24 15:55:29 UTC) #3
Shezan Baig (Bloomberg)
On 2014/09/24 15:55:29, scottmg wrote: > Nice test! LGTM. Thanks :) Is it still 'git ...
6 years, 3 months ago (2014-09-24 16:02:49 UTC) #4
Shezan Baig (Bloomberg)
The gyp-win32 failure (gyptest-link-target-machine) seems to be caused by r1981
6 years, 3 months ago (2014-09-24 17:05:02 UTC) #5
Shezan Baig (Bloomberg)
PTAL -- I removed the /Gv support. This flag is only available in MSVC2013, so ...
6 years, 3 months ago (2014-09-24 21:47:38 UTC) #6
scottmg
On 2014/09/24 21:47:38, Shezan Baig (Bloomberg) wrote: > PTAL -- I removed the /Gv support. ...
6 years, 3 months ago (2014-09-24 21:51:15 UTC) #7
Shezan Baig (Bloomberg)
6 years, 3 months ago (2014-09-24 21:53:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 1984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698