Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 597983003: Refactor PasswordAutofillAgent: methods to functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit changes. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index daeb291eeb71681e069426c35efaf811488b8f32..616c7f8c0f9a7969d2e0943a2890b1a8589ebf46 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -153,31 +153,10 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
// If |only_visible| is true, only forms visible in the layout are sent.
void SendPasswordForms(blink::WebFrame* frame, bool only_visible);
- void GetSuggestions(const PasswordFormFillData& fill_data,
- const base::string16& input,
- std::vector<base::string16>* suggestions,
- std::vector<base::string16>* realms,
- bool show_all);
-
bool ShowSuggestionPopup(const PasswordFormFillData& fill_data,
const blink::WebInputElement& user_input,
bool show_all);
- // Attempts to fill |username_element| and |password_element| with the
- // |fill_data|. Will use the data corresponding to the preferred username,
- // unless the |username_element| already has a value set. In that case,
- // attempts to fill the password matching the already filled username, if
- // such a password exists.
- void FillFormOnPasswordRecieved(const PasswordFormFillData& fill_data,
- blink::WebInputElement username_element,
- blink::WebInputElement password_element);
-
- bool FillUserNameAndPassword(blink::WebInputElement* username_element,
- blink::WebInputElement* password_element,
- const PasswordFormFillData& fill_data,
- bool exact_username_match,
- bool set_selection);
-
// Fills |login_input| and |password| with the most relevant suggestion from
// |fill_data| and shows a popup with other suggestions.
void PerformInlineAutocomplete(

Powered by Google App Engine
This is Rietveld 408576698