Refactor PasswordAutofillAgent: methods to functions.

components/autofill/content/renderer/password_autofill_agent.h

Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index daeb291eeb71681e069426c35efaf811488b8f32..eea3aadcac68b80c204803c813f1de093d7da3c4 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -23,6 +23,16 @@ class WebView;
 
 namespace autofill {
 
+// This struct is used in helper function to indicate parameter modification.

[vabr (Chromium), 2014/09/25 10:25:49]

Please don't introduce this struct. I indicated below in the comments, how you
can do this without it.

(BTW., just for the future: even if you needed it, the right place to define it
would be in the .cc file, because it is only used by the methods in the .cc
file.)

[Deepak, 2014/09/25 12:02:26]

Thanks,I will take care in future.

+struct ParametersNeedUpdate {
+  bool usernames_usage;
+  bool gate_keeper;
+  ParametersNeedUpdate() {

[vabr (Chromium), 2014/09/25 10:25:49]

(Just for future: it is considered better practice to initialise the member
variables through the constructor's member initialiser list:
ParametersNeedUpdate() : usernames_usage(false), gate_keeper(false) {}
That's more readable, and can be more efficient for more complex data members,
where construction and assignment takes more time than just construction with
the right values.)

[Deepak, 2014/09/25 12:02:26]

Thanks,I will take care in future.

+    usernames_usage = false;
+    gate_keeper = false;
+  };
+};
+
 // This class is responsible for filling password forms.
 // There is one PasswordAutofillAgent per RenderView.
 class PasswordAutofillAgent : public content::RenderViewObserver {
@@ -153,30 +163,10 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
   // If |only_visible| is true, only forms visible in the layout are sent.
   void SendPasswordForms(blink::WebFrame* frame, bool only_visible);
 
-  void GetSuggestions(const PasswordFormFillData& fill_data,
-                      const base::string16& input,
-                      std::vector<base::string16>* suggestions,
-                      std::vector<base::string16>* realms,
-                      bool show_all);
-
   bool ShowSuggestionPopup(const PasswordFormFillData& fill_data,
                            const blink::WebInputElement& user_input,
                            bool show_all);
 
-  // Attempts to fill |username_element| and |password_element| with the
-  // |fill_data|.  Will use the data corresponding to the preferred username,
-  // unless the |username_element| already has a value set.  In that case,
-  // attempts to fill the password matching the already filled username, if
-  // such a password exists.
-  void FillFormOnPasswordRecieved(const PasswordFormFillData& fill_data,
-                                  blink::WebInputElement username_element,
-                                  blink::WebInputElement password_element);
-
-  bool FillUserNameAndPassword(blink::WebInputElement* username_element,
-                               blink::WebInputElement* password_element,
-                               const PasswordFormFillData& fill_data,
-                               bool exact_username_match,
-                               bool set_selection);
 
   // Fills |login_input| and |password| with the most relevant suggestion from
   // |fill_data| and shows a popup with other suggestions.