Use runtime.h to look for runtime function names.

Use runtime.h to look for runtime function names.

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24201

[Jakob Kummerow, 2014-09-24 10:53:13]

LGTM with comments. Happy to take another look if you end up making significant
changes.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py
File tools/check-name-clashes.py (right):

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:13: LISTBODY = re.compile(".*\\\\$")
nit: if you use Python's r"..." notation, that'll save you one level of
backslash-escaping.
Also, I think you want to make the trailing backslash optional, or you won't
match the last line in each macro.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:43: for line in lines:
I'd inline ReadFile here and iterate over the opened file's lines directly.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:63: if ListName(list) in BLACKLIST:
I'd be inclined to move this logic into the first line matching loop as well,
but I'm not sure it's worth it (since it makes the logic there more complex, and
doesn't really avoid any computation), so I'm leaving it up to you.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:70: print(match.group(1))
debugging leftover?

[Yang, 2014-09-24 11:52:17]

Another look please.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py
File tools/check-name-clashes.py (right):

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:13: LISTBODY = re.compile(".*\\\\$")
On 2014/09/24 10:53:13, Jakob wrote:
> nit: if you use Python's r"..." notation, that'll save you one level of
> backslash-escaping.
> Also, I think you want to make the trailing backslash optional, or you won't
> match the last line in each macro.

Done.

The loop is written in a way to append the first non-matching line before
switching to look for LISTHEAD, so it works out.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:43: for line in lines:
On 2014/09/24 10:53:13, Jakob wrote:
> I'd inline ReadFile here and iterate over the opened file's lines directly.

Done.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:63: if ListName(list) in BLACKLIST:
On 2014/09/24 10:53:13, Jakob wrote:
> I'd be inclined to move this logic into the first line matching loop as well,
> but I'm not sure it's worth it (since it makes the logic there more complex,
and
> doesn't really avoid any computation), so I'm leaving it up to you.

Done.

https://codereview.chromium.org/597943002/diff/1/tools/check-name-clashes.py#...
tools/check-name-clashes.py:70: print(match.group(1))
On 2014/09/24 10:53:13, Jakob wrote:
> debugging leftover?

Done.

[Jakob Kummerow, 2014-09-24 12:08:24]

lgtm

https://codereview.chromium.org/597943002/diff/2/tools/check-name-clashes.py
File tools/check-name-clashes.py (right):

https://codereview.chromium.org/597943002/diff/2/tools/check-name-clashes.py#...
tools/check-name-clashes.py:13: LISTBODY = re.compile(".*\\\\$")
I meant using r"" here, so you'd get:
re.compile(r".*\\$")

[Yang, 2014-09-25 07:04:41]

Committed patchset #4 (id:50001) manually as 24201 (presubmit successful).