Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59793008: sync: don't allow NULL profile in ProfileSyncService and friends (Closed)

Created:
7 years, 1 month ago by tim (not reviewing)
Modified:
7 years, 1 month ago
Reviewers:
rlarocque, Matt Perry
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, lipalani1
Visibility:
Public.

Description

sync: don't allow NULL profile in ProfileSyncService and friends BUG=130176 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234655

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -137 lines) Patch
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/invalidation/invalidator_storage.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/invalidation/invalidator_storage.cc View 8 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/shared_change_processor_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 13 chunks +18 lines, -57 lines 0 comments Download
M chrome/browser/sync/sync_prefs_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tim (not reviewing)
7 years, 1 month ago (2013-11-11 16:34:24 UTC) #1
rlarocque
LGTM!
7 years, 1 month ago (2013-11-11 18:25:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/59793008/450001
7 years, 1 month ago (2013-11-11 23:29:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35585
7 years, 1 month ago (2013-11-12 00:14:07 UTC) #4
tim (not reviewing)
+TBR mpcomplete for boilerplate change in signed_in_devices/
7 years, 1 month ago (2013-11-12 00:58:42 UTC) #5
Matt Perry
LGTM +lipalani - please add an OWNERS file to the signed_in_devices directory and add yourself ...
7 years, 1 month ago (2013-11-12 01:02:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/59793008/450001
7 years, 1 month ago (2013-11-12 01:11:30 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=188173
7 years, 1 month ago (2013-11-12 02:55:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/59793008/450001
7 years, 1 month ago (2013-11-12 07:24:00 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=174129
7 years, 1 month ago (2013-11-12 08:41:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/59793008/1110001
7 years, 1 month ago (2013-11-12 19:21:28 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 22:44:17 UTC) #12
Message was sent while issue was closed. 
Change committed as 234655

Powered by Google App Engine
This is Rietveld 408576698