Issue 59793003: Emit CommitFrame and BeginFrame for impl-side frames

Issue 59793003: Emit CommitFrame and BeginFrame for impl-side frames (Closed)

Created:
7 years, 1 month ago by caseq

Modified:
7 years ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Emit CommitFrame and BeginFrame for impl-side frames This adds processing of CommitFrame and BeginFrame to TimelineTraceEventProcessor. BUG=305863 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163167

Patch Set 3 : rebased on top of TraceEventDispatcher refactoring #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -7 lines)			Patch
M	Source/core/inspector/InspectorInstrumentation.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.h	View	1 2	7 chunks	+8 lines, -5 lines	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View	1 2	6 chunks	+30 lines, -2 lines	0 comments	Download
M	Source/core/inspector/TraceEventDispatcher.cpp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/platform/TraceEvent.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm. I'd start with re-aligning the macros. https://chromiumcodereview.appspot.com/59793003/diff/1/Source/core/inspector/TimelineTraceEventProcessor.h File Source/core/inspector/TimelineTraceEventProcessor.h (right): https://chromiumcodereview.appspot.com/59793003/diff/1/Source/core/inspector/TimelineTraceEventProcessor.h#newcode246 Source/core/inspector/TimelineTraceEventProcessor.h:246: bool m_mainThreadFrameBeingRendered; ...

7 years, 1 month ago (2013-11-06 17:07:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/59793003/80001

7 years ago (2013-12-03 11:47:07 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4495

7 years ago (2013-12-03 14:20:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/59793003/100001

7 years ago (2013-12-04 08:28:47 UTC) #6

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19475

7 years ago (2013-12-04 11:28:39 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r163167 (presubmit successful).

Expand Messages | Collapse Messages