Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 59793002: sh implementation to avoid unwanted resizes during iteration. (Closed)

Created:
7 years, 1 month ago by digit1
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/openssl/
Visibility:
Public.

Description

sh implementation to avoid unwanted resizes during iteration. This is a port of the following AOSP patch: https://android-review.googlesource.com/#/c/68853/ It fixes a bug that happens when trying to delete items from a lhash table while it is being iterated over with a call to lh_doall or lh_doall_arg. It looks like the source tree is slightly out-of-sync from the state of running ./import_from_android.sh, but the differences are minor / not significant. This patch tries to fix a P1 bug, so doesn't try to address this (the differences have been removed for easier reviewing). BUG=298606 R=agl@chromium.org,rsleevi@chromium.org,wtc@chromium.org TBR=darin@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -20 lines) Patch
M README.chromium View 1 chunk +5 lines, -0 lines 0 comments Download
M openssl/crypto/conf/conf_api.c View 1 chunk +0 lines, -3 lines 0 comments Download
M openssl/crypto/lhash/lhash.h View 1 chunk +1 line, -0 lines 0 comments Download
M openssl/crypto/lhash/lhash.c View 8 chunks +132 lines, -7 lines 0 comments Download
M openssl/crypto/objects/o_names.c View 2 chunks +0 lines, -6 lines 0 comments Download
M openssl/crypto/objects/obj_dat.c View 1 chunk +0 lines, -1 line 0 comments Download
M openssl/include/openssl/lhash.h View 1 chunk +1 line, -0 lines 0 comments Download
M openssl/openssl.config View 2 chunks +11 lines, -0 lines 0 comments Download
M openssl/ssl/ssl_sess.c View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
digit1
This is a trivial svn-based re-upload of https://chromiumcodereview.appspot.com/57833003/ given that "git cl push" doesn't seem ...
7 years, 1 month ago (2013-11-05 12:45:38 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-05 17:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/59793002/1
7 years, 1 month ago (2013-11-05 17:28:25 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 17:28:54 UTC) #4
Message was sent while issue was closed.
Change committed as 233017

Powered by Google App Engine
This is Rietveld 408576698