Condition the ShowManageSSLCertificates button on operating system.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 683 matching lines @@
       base::Bind(&BrowserOptionsHandler::HandleAutoOpenButton,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "defaultFontSizeAction",
       base::Bind(&BrowserOptionsHandler::HandleDefaultFontSize,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "defaultZoomFactorAction",
       base::Bind(&BrowserOptionsHandler::HandleDefaultZoomFactor,
                  base::Unretained(this)));
-#if !defined(USE_NSS) && !defined(USE_OPENSSL)

[Dan Beam, 2014/09/24 18:41:08]

why not add a USE_BORINGSSL?

[davidben, 2014/09/24 18:50:15]

The problem isn't OpenSSL -> BoringSSL (all references in code still say OpenSSL
right now; BoringSSL is our in-house OpenSSL). It's Mac going NSS ->
OpenSSL/BoringSSL. These flags are kinda awkward and really should be renamed.
They match the GYP flags which are similarly confused. I believe GN's flags were
newer so they get it right. There's:

USE_NSS = port uses NSS for /certificates/. This is currently CrOS and Linux.
USE_OPENSSL = port uses OpenSSL for /all crypto/. If undefined, general crypto
is NSS. This used to be only Android. Now it's Mac as well. Eventually it will
be everything and there won't be any NSS anywhere.
USE_OPENSSL_CERTS = port uses OpenSSL for /certificates/. This is just Android
and the unfinished Linux+OpenSSL port.

So USE_NSS is really USE_NSS_CERTS and what should be USE_NSS is
!defined(USE_OPENSSL).

One fix would be to replace USE_OPENSSL with USE_OPENSSL_CERTS. I can flip it
that way if you prefer. That would work as well. (This code should be built on
Mac.) I opted to flip it to the OS ones because this is the other half to the
showManageSSLCertificates message, and that one is keyed by OS.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

+#if defined(OS_WIN) || defined(OS_MACOSX)
   web_ui()->RegisterMessageCallback(
       "showManageSSLCertificates",
       base::Bind(&BrowserOptionsHandler::ShowManageSSLCertificates,
                  base::Unretained(this)));
 #endif
 #if defined(OS_CHROMEOS)
   web_ui()->RegisterMessageCallback(
       "openWallpaperManager",
       base::Bind(&BrowserOptionsHandler::HandleOpenWallpaperManager,
                  base::Unretained(this)));
@@ skipping 855 matching lines @@
 
 #if !defined(OS_CHROMEOS)
 void BrowserOptionsHandler::ShowNetworkProxySettings(
     const base::ListValue* args) {
   content::RecordAction(UserMetricsAction("Options_ShowProxySettings"));
   AdvancedOptionsUtilities::ShowNetworkProxySettings(
       web_ui()->GetWebContents());
 }
 #endif
 
-#if !defined(USE_NSS) && !defined(USE_OPENSSL)
+#if defined(OS_WIN) || defined(OS_MACOSX)
 void BrowserOptionsHandler::ShowManageSSLCertificates(
     const base::ListValue* args) {
   content::RecordAction(UserMetricsAction("Options_ManageSSLCertificates"));
   AdvancedOptionsUtilities::ShowManageSSLCertificates(
       web_ui()->GetWebContents());
 }
 #endif
 
 #if defined(ENABLE_SERVICE_DISCOVERY)
 
@@ skipping 334 matching lines @@
 
 void BrowserOptionsHandler::SetMetricsReportingCheckbox(bool checked,
                                                         bool disabled) {
   web_ui()->CallJavascriptFunction(
       "BrowserOptions.setMetricsReportingCheckboxState",
       base::FundamentalValue(checked),
       base::FundamentalValue(disabled));
 }
 
 }  // namespace options