src/objects.cc - Issue 597893002: Version 3.28.71.12 (merged r24125)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 597893002: Version 3.28.71.12 (merged r24125) (Closed) Base URL: https://v8.googlecode.com/svn/branches/3.28

Patch Set: move check to SetNormalizedProperty Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 75b5860f8ef63bf9d45f9b0f917b0f6702b38c04..a994718bd079007a3af15c4b7fa7577547672f2a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -693,7 +693,7 @@ void JSObject::SetNormalizedProperty(Handle<JSObject> object,

Handle<Name> name,

Handle<Object> value,

PropertyDetails details) {

- DCHECK(!object->HasFastProperties());

+ CHECK(!object->HasFastProperties());

Handle<NameDictionary> property_dictionary(object->property_dictionary());

if (!name->IsUniqueName()) {

« no previous file with comments | « src/json-parser.h ('k') | src/version.cc » ('j') | no next file with comments »