Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 597873004: Revert of Another attempt to fix debug info stripping for ASan on OSX (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Another attempt to fix debug info stripping for ASan on OSX (patchset #5 id:80001 of https://codereview.chromium.org/560323004/) Reason for revert: Broke mac asan content_browsertests: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%281%29/builds/4311/steps/content_browsertests/logs/stdio Original issue's description: > Another attempt to fix debug info stripping for ASan on OSX > > Unce upon a time the ASan runtime library used to be statically linked into > the executables on OSX. > Because that library provided a number of API functions needed by the shared > libraries, we had custom ASan-specific .saves files that told the `strip` > utility to preserve those functions when stripping the executables. > > Then ASan switched to using dynamic runtime library, which instantly broke the > stripping step, because the executables weren't necessarily referencing all the > ASan API functions (issue 242503). > As a result, stripping has been disabled, and we haven't had .dSYM debug info > for ASan builds for more than a year now (issue 148383). > > Because the ASan API functions are now undefined in the executables, it's > actually senseless to use the .saves files to preserve those functions in each > executable. However __asan_default_options still must be preserved to be accessible > from the ASan runtime. > > This CL removes all ASan symbols except for __asan_default_options from the .saves files > and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves. > It also turns mac_strip_release on for ASan builds. > > BUG=148383, 242503, 170739, 166857 > R=mark@chromium.org > TBR=cpu@chromium.org > > Committed: https://crrev.com/d051b21c75afc414190db331fd608cc61e3056dc > Cr-Commit-Position: refs/heads/master@{#296413} TBR=mark@chromium.org,cpu@chromium.org,glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=148383, 242503, 170739, 166857 Committed: https://crrev.com/55c7faab2f0ce87d91d4cb995a41bb260210e773 Cr-Commit-Position: refs/heads/master@{#296434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M build/asan.saves View 1 chunk +17 lines, -3 lines 0 comments Download
M build/common.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/app_asan.saves View 1 chunk +19 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jiayl
Created Revert of Another attempt to fix debug info stripping for ASan on OSX
6 years, 3 months ago (2014-09-24 16:24:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597873004/1
6 years, 3 months ago (2014-09-24 16:24:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 54d0012926a83b633a39fec92b68e3d4458079a7
6 years, 3 months ago (2014-09-24 16:25:25 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 16:25:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55c7faab2f0ce87d91d4cb995a41bb260210e773
Cr-Commit-Position: refs/heads/master@{#296434}

Powered by Google App Engine
This is Rietveld 408576698