Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 597873002: Remove page_ordinal from AppListSpecifics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.h ('k') | sync/protocol/app_list_specifics.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_syncable_service.cc
diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc
index 2dc36f20008e9e34b0c47b25b3ba2946fbfa5ced..f4d38d99435653204034badc8b1bda7df44e83f4 100644
--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc
+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc
@@ -51,8 +51,6 @@ void UpdateSyncItemFromSync(const sync_pb::AppListSpecifics& specifics,
item->item_type = specifics.item_type();
item->item_name = specifics.item_name();
item->parent_id = specifics.parent_id();
- if (!specifics.page_ordinal().empty())
- item->page_ordinal = syncer::StringOrdinal(specifics.page_ordinal());
if (!specifics.item_ordinal().empty())
item->item_ordinal = syncer::StringOrdinal(specifics.item_ordinal());
}
@@ -75,7 +73,6 @@ bool UpdateSyncItemFromAppItem(const AppListItem* app_item,
sync_item->item_ordinal = app_item->position();
changed = true;
}
- // TODO(stevenjb): Set page_ordinal.
return changed;
}
@@ -86,8 +83,6 @@ void GetSyncSpecificsFromSyncItem(const AppListSyncableService::SyncItem* item,
specifics->set_item_type(item->item_type);
specifics->set_item_name(item->item_name);
specifics->set_parent_id(item->parent_id);
- if (item->page_ordinal.IsValid())
- specifics->set_page_ordinal(item->page_ordinal.ToInternalValue());
if (item->item_ordinal.IsValid())
specifics->set_item_ordinal(item->item_ordinal.ToInternalValue());
}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.h ('k') | sync/protocol/app_list_specifics.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698