Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 597873002: Remove page_ordinal from AppListSpecifics. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea, Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org, tfarina, haitaol+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove page_ordinal from AppListSpecifics. This CL deprecates a field from a sync proto because it was not being used and isn't part of the model. BUG=372264 Committed: https://crrev.com/0e83c8a1b0a5d5cadc57360c682f29f68fd42cc3 Cr-Commit-Position: refs/heads/master@{#298583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M sync/protocol/app_list_specifics.proto View 1 chunk +2 lines, -1 line 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
calamity
6 years, 2 months ago (2014-09-30 05:42:04 UTC) #2
Matt Giuca
lgtm You could add a bit more to the CL description explaining why this is ...
6 years, 2 months ago (2014-09-30 05:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597873002/1
6 years, 2 months ago (2014-10-03 02:55:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15234)
6 years, 2 months ago (2014-10-03 03:02:53 UTC) #7
calamity
+zea for sync/ OWNERS
6 years, 2 months ago (2014-10-03 03:56:12 UTC) #9
Nicolas Zea
lgtm
6 years, 2 months ago (2014-10-03 17:54:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597873002/1
6 years, 2 months ago (2014-10-07 21:55:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2bd7d53c3c0869f832b8165cae699fde4158e5b5
6 years, 2 months ago (2014-10-07 22:01:17 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 22:02:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e83c8a1b0a5d5cadc57360c682f29f68fd42cc3
Cr-Commit-Position: refs/heads/master@{#298583}

Powered by Google App Engine
This is Rietveld 408576698