tools/clang/plugins/tests/virtual_methods.txt - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/virtual_methods.txt

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/tests/virtual_methods.txt

diff --git a/tools/clang/plugins/tests/virtual_methods.txt b/tools/clang/plugins/tests/virtual_methods.txt

index 3e484cd5fefc2792b229fe2863c2b3214ee766dc..d8fdb19a9a17d637cbd3e0a48aabbb430d738f2f 100644

--- a/tools/clang/plugins/tests/virtual_methods.txt

+++ b/tools/clang/plugins/tests/virtual_methods.txt

@@ -2,8 +2,4 @@ In file included from virtual_methods.cpp:5:

./virtual_methods.h:17:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline.

virtual bool ComplainAboutThis() { return true; }

-./virtual_methods.h:23:3: warning: [chromium-style] Overriding method must have "virtual" keyword.

- void MethodHasNoArguments() override;

- ^

- virtual

-2 warnings generated.

+1 warning generated.

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/virtual_method_overannotated.txt ('k') | no next file » | no next file with comments »