tools/clang/plugins/tests/virtual_base_method_also_final.txt - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/virtual_base_method_also_final.txt

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/virtual_base_method_also_final.flags ('k') | tools/clang/plugins/tests/virtual_dtor_only_override.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/plugins/tests/virtual_base_method_also_final.txt

diff --git a/tools/clang/plugins/tests/virtual_base_method_also_final.txt b/tools/clang/plugins/tests/virtual_base_method_also_final.txt

new file mode 100644

index 0000000000000000000000000000000000000000..b81eb60e0ced7b5a4f62f16dcb49fafa70149db2

--- /dev/null

+++ b/tools/clang/plugins/tests/virtual_base_method_also_final.txt

@@ -0,0 +1,7 @@

+virtual_base_method_also_final.cpp:3:3: warning: [chromium-style] virtual is redundant; 'final' implies virtual.

+ virtual void F() final {}

+ ^~~~~~~~

+virtual_base_method_also_final.cpp:3:3: warning: [chromium-style] a virtual method on a base class should not also be final; method should be devirtualized

+ virtual void F() final {}

+ ^~~~~~~~ ~~~~~~

+2 warnings generated.