Index: tools/clang/plugins/tests/virtual_method_specifiers.cpp |
diff --git a/tools/clang/plugins/tests/virtual_method_specifiers.cpp b/tools/clang/plugins/tests/virtual_method_specifiers.cpp |
new file mode 100644 |
index 0000000000000000000000000000000000000000..d12aabf6ef450ef8c2ac83f58c7d53520b5f7a65 |
--- /dev/null |
+++ b/tools/clang/plugins/tests/virtual_method_specifiers.cpp |
@@ -0,0 +1,51 @@ |
+// Tests for chromium style checks for virtual/override/final specifiers on |
+// virtual methods. |
+ |
+// Purposely use macros to test that the FixIt hints don't try to remove the |
+// macro body. |
+#define OVERRIDE override |
+#define FINAL final |
+ |
+// Base class can only use virtual. |
+class Base { |
+ public: |
+ virtual void F() = 0; |
+}; |
+ |
+// Derived classes correctly use only override or final specifier. |
+class CorrectOverride : public Base { |
+ public: |
+ void F() OVERRIDE {} |
+}; |
+ |
+class CorrectFinal : public CorrectOverride { |
+ public: |
+ void F() FINAL {} |
+}; |
+ |
+// No override on an overridden method should trigger a diagnostic. |
+class MissingOverride : public Base { |
+ public: |
+ virtual void F() {} |
+}; |
+ |
+// Redundant specifiers should trigger a diagnostic. |
+class VirtualAndOverride : public Base { |
+ public: |
+ virtual void F() OVERRIDE {} |
+}; |
+ |
+class VirtualAndFinal : public Base { |
+ public: |
+ virtual void F() FINAL {} |
+}; |
+ |
+class VirtualAndOverrideFinal : public Base { |
+ public: |
+ virtual void F() OVERRIDE FINAL {} |
+}; |
+ |
+class OverrideAndFinal : public Base { |
+ public: |
+ void F() OVERRIDE FINAL {} |
+}; |