tools/clang/plugins/tests/test.sh - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/test.sh

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/annotation/specifier/g Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/overridden_methods.txt ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.cpp » ('j') | tools/clang/plugins/tests/virtual_dtor_specifiers.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/plugins/tests/test.sh

diff --git a/tools/clang/plugins/tests/test.sh b/tools/clang/plugins/tests/test.sh

index 7946325c539dd36ea9c8c9b35a9cbbaae8c0af48..078c0b054a07b26d77e96d9c3b1fd13f560c03c8 100755

--- a/tools/clang/plugins/tests/test.sh

+++ b/tools/clang/plugins/tests/test.sh

@@ -33,7 +33,7 @@ do_testcase() {

flags="${flags} -isysroot $(xcrun --show-sdk-path) -stdlib=libstdc++"

- local output="$("${CLANG_PATH}" -c -Wno-c++11-extensions \

+ local output="$("${CLANG_PATH}" -fsyntax-only -c -Wno-c++11-extensions \

hans 2014/09/26 01:29:29 can probably drop the -c now that we pass -fsyntax

dcheng 2014/09/26 07:07:14 Done.

-Xclang -load -Xclang "${PLUGIN_PATH}" \

-Xclang -add-plugin -Xclang find-bad-constructs ${flags} ${1} 2>&1)"

local diffout="$(echo "${output}" | diff - "${2}")"

@@ -44,6 +44,10 @@ do_testcase() {

echo "FAIL: ${1}"

echo "Output of compiler:"

echo "${output}"

+ cat > ${2}-actual << EOF

hans 2014/09/26 01:29:29 Won't this leave a file in the source tree? It see

dcheng 2014/09/26 07:07:14 Only if there's a diff. It makes it much easier to

hans 2014/09/27 00:36:09 Oh, right. That makes sense.

+${output}

+EOF

echo "Expected output:"

cat "${2}"

echo