tools/clang/plugins/tests/virtual_method_overannotated.txt - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/virtual_method_overannotated.txt

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/virtual_method_overannotated.flags ('k') | tools/clang/plugins/tests/virtual_methods.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 virtual_method_overannotated.cpp:11:3: warning: [chromium-style] virtual is redu ndant; 'override' implies virtual.

	2 virtual void F1() override {}

	3 ^~~~~~~~

	4 virtual_method_overannotated.cpp:12:3: warning: [chromium-style] virtual is redu ndant; 'final' implies virtual.

	5 virtual void F2() final {}

	6 ^~~~~~~~

	7 virtual_method_overannotated.cpp:13:3: warning: [chromium-style] virtual is redu ndant; 'override' implies virtual.

	8 virtual void F3() override final {}

	9 ^~~~~~~~

	10 virtual_method_overannotated.cpp:13:21: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.

	11 virtual void F3() override final {}

	12 ^~~~~~~~~

	13 4 warnings generated.

OLD	NEW