Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: tools/clang/plugins/tests/virtual_specifiers.txt

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add copyright blurb Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.flags ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 virtual_specifiers.cpp:36:21: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
2 ~MissingOverride() {}
3 ^
4 override
5 virtual_specifiers.cpp:37:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
6 void F() {}
7 ^
8 override
9 virtual_specifiers.cpp:43:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
10 virtual ~VirtualAndOverride() OVERRIDE {}
11 ^~~~~~~~
12 virtual_specifiers.cpp:44:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
13 virtual void F() OVERRIDE {}
14 ^~~~~~~~
15 virtual_specifiers.cpp:49:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'.
16 virtual ~VirtualAndFinal() FINAL {}
17 ^~~~~~~~
18 virtual_specifiers.cpp:50:3: warning: [chromium-style] 'virtual' is redundant; ' final' implies 'virtual'.
19 virtual void F() FINAL {}
20 ^~~~~~~~
21 virtual_specifiers.cpp:55:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
22 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
23 ^~~~~~~~
24 virtual_specifiers.cpp:55:38: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
25 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
26 ^~~~~~~~~
27 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'
28 #define OVERRIDE override
29 ^
30 virtual_specifiers.cpp:56:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.
31 virtual void F() OVERRIDE FINAL {}
32 ^~~~~~~~
33 virtual_specifiers.cpp:56:20: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
34 virtual void F() OVERRIDE FINAL {}
35 ^~~~~~~~~
36 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'
37 #define OVERRIDE override
38 ^
39 virtual_specifiers.cpp:61:23: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
40 ~OverrideAndFinal() OVERRIDE FINAL {}
41 ^~~~~~~~~
42 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'
43 #define OVERRIDE override
44 ^
45 virtual_specifiers.cpp:62:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
46 void F() OVERRIDE FINAL {}
47 ^~~~~~~~~
48 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'
49 #define OVERRIDE override
50 ^
51 12 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.flags ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698