OLD | NEW |
(Empty) | |
| 1 // Tests for chromium style checks for virtual/override/final specifiers on |
| 2 // virtual methods. |
| 3 |
| 4 // Purposely use macros to test that the FixIt hints don't try to remove the |
| 5 // macro body. |
| 6 #define OVERRIDE override |
| 7 #define FINAL final |
| 8 |
| 9 // Base class can only use virtual. |
| 10 class Base { |
| 11 public: |
| 12 virtual ~Base() {} |
| 13 virtual void F() = 0; |
| 14 }; |
| 15 |
| 16 // Derived classes correctly use only override or final specifier. |
| 17 class CorrectOverride : public Base { |
| 18 public: |
| 19 ~CorrectOverride() OVERRIDE {} |
| 20 void F() OVERRIDE {} |
| 21 }; |
| 22 |
| 23 class CorrectFinal : public CorrectOverride { |
| 24 public: |
| 25 ~CorrectFinal() FINAL {} |
| 26 void F() FINAL {} |
| 27 }; |
| 28 |
| 29 // No override on an overridden method should trigger a diagnostic. |
| 30 class MissingOverride : public Base { |
| 31 public: |
| 32 ~MissingOverride() {} |
| 33 void F() {} |
| 34 }; |
| 35 |
| 36 // Redundant specifiers should trigger a diagnostic. |
| 37 class VirtualAndOverride : public Base { |
| 38 public: |
| 39 virtual ~VirtualAndOverride() OVERRIDE {} |
| 40 virtual void F() OVERRIDE {} |
| 41 }; |
| 42 |
| 43 class VirtualAndFinal : public Base { |
| 44 public: |
| 45 virtual ~VirtualAndFinal() FINAL {} |
| 46 virtual void F() FINAL {} |
| 47 }; |
| 48 |
| 49 class VirtualAndOverrideFinal : public Base { |
| 50 public: |
| 51 virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {} |
| 52 virtual void F() OVERRIDE FINAL {} |
| 53 }; |
| 54 |
| 55 class OverrideAndFinal : public Base { |
| 56 public: |
| 57 ~OverrideAndFinal() OVERRIDE FINAL {} |
| 58 void F() OVERRIDE FINAL {} |
| 59 }; |
OLD | NEW |