tools/clang/plugins/tests/virtual_base_method_also_final.txt - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/virtual_base_method_also_final.txt

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: And one more thing... Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/clang/plugins/tests/virtual_base_method_also_final.cpp ('K') | « tools/clang/plugins/tests/virtual_base_method_also_final.flags ('k') | tools/clang/plugins/tests/virtual_bodies.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 virtual_base_method_also_final.cpp:5:3: warning: [chromium-style] 'virtual' is r edundant; 'final' implies 'virtual'.

	2 VIRTUAL void F() final {}

	3 ^~~~~~~~

	4 virtual_base_method_also_final.cpp:1:17: note: expanded from macro 'VIRTUAL'

	5 #define VIRTUAL virtual

	6 ^

	7 virtual_base_method_also_final.cpp:5:3: warning: [chromium-style] The virtual me thod does not override anything and is final; consider making it non-virtual.

	8 VIRTUAL void F() final {}

	9 ^~~~~~~~ ~~~~~~

	10 virtual_base_method_also_final.cpp:1:17: note: expanded from macro 'VIRTUAL'

	11 #define VIRTUAL virtual

	12 ^

	13 virtual_base_method_also_final.cpp:8:3: warning: [chromium-style] 'virtual' is r edundant; 'final' implies 'virtual'.

	14 void VIRTUAL G() final {}

	15 ^

	16 virtual_base_method_also_final.cpp:8:3: warning: [chromium-style] The virtual me thod does not override anything and is final; consider making it non-virtual.

	17 void VIRTUAL G() final {}

	18 ^ ~~~~~~

	19 4 warnings generated.

OLD	NEW