Update the AvatarMenu when a supervised user's custodian info changes.

Update the AvatarMenu (and the ProfileChooserView, which listens for changes to the AvatarMenu) when a supervised user's custodian info changes.

BUG=372381
Committed: https://crrev.com/3fce4e99a7b91b6ff5ea1036c4984f97e373ab76
Cr-Commit-Position: refs/heads/master@{#296954}

[Marc Treib, 2014-09-25 11:06:32]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org, noms@chromium.org

[Marc Treib, 2014-09-25 11:06:33]

PTAL!

noms@chromium.org: Please review changes in c/b/profiles.

bauerb@chromium.org: Please review changes in c/b/supervised_user.

[noms (inactive), 2014-09-25 14:22:23]

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:73:
SupervisedUserServiceFactory::GetForProfile(browser_->profile());
Is it possible to be in a state where browser_->profile() is the Guest Profile,
for which service might be NULL?

[Marc Treib, 2014-09-25 14:50:56]

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:73:
SupervisedUserServiceFactory::GetForProfile(browser_->profile());
On 2014/09/25 14:22:22, Monica Dinculescu wrote:
> Is it possible to be in a state where browser_->profile() is the Guest
Profile,
> for which service might be NULL? 

browser_->profile() can be the guest profile, but service still isn't NULL.
Maybe it can be NULL in tests? I haven't checked that yet.

[Bernhard Bauer, 2014-09-25 15:15:48]

supervised_user/ LGTM.

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:73:
SupervisedUserServiceFactory::GetForProfile(browser_->profile());
On 2014/09/25 14:50:56, Marc Treib wrote:
> On 2014/09/25 14:22:22, Monica Dinculescu wrote:
> > Is it possible to be in a state where browser_->profile() is the Guest
> Profile,
> > for which service might be NULL? 
> 
> browser_->profile() can be the guest profile, but service still isn't NULL.
> Maybe it can be NULL in tests? I haven't checked that yet.

Yeah, I don't think we set it to NULL for testing profiles.

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:84: service->RemoveObserver(this);
A ScopedObserver might be useful here, to do this automatically at destruction.

[Marc Treib, 2014-09-25 15:30:28]

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:84: service->RemoveObserver(this);
On 2014/09/25 15:15:48, Bernhard Bauer wrote:
> A ScopedObserver might be useful here, to do this automatically at
destruction.

Done.

[noms (inactive), 2014-09-25 15:36:18]

profiles lgtm

[Bernhard Bauer, 2014-09-25 16:11:20]

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:77:
supervised_user_observer_.Add(service);
You could even inline |service| now?

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.h (right):

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:23: #include "base/scoped_observer.h"
For sake of simplicity, I would include this unconditionally.

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:35: class SupervisedUserService;
Same here, forward-declare this unconditionally. It doesn't add to compile time,
and trying to use it will fail because the header isn't included (and can't be).

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:172: supervised_user_observer_;
Indent two more spaces.

[Marc Treib, 2014-09-25 16:17:17]

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.cc:77:
supervised_user_observer_.Add(service);
On 2014/09/25 16:11:19, Bernhard Bauer wrote:
> You could even inline |service| now?

Done.

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/avatar_menu.h (right):

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:23: #include "base/scoped_observer.h"
On 2014/09/25 16:11:19, Bernhard Bauer wrote:
> For sake of simplicity, I would include this unconditionally.

Done.

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:35: class SupervisedUserService;
On 2014/09/25 16:11:19, Bernhard Bauer wrote:
> Same here, forward-declare this unconditionally. It doesn't add to compile
time,
> and trying to use it will fail because the header isn't included (and can't
be).

Done.

https://codereview.chromium.org/597783003/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/avatar_menu.h:172: supervised_user_observer_;
On 2014/09/25 16:11:19, Bernhard Bauer wrote:
> Indent two more spaces.

Done.

[Marc Treib, 2014-09-26 09:28:19]

Ping@noms, in case you want to take another look: I had to update
ProfileListDesktopBrowserTest so that the AvatarMenu doesn't outlive the
Profile.

[noms (inactive), 2014-09-26 14:19:02]

slgtm

[Marc Treib, 2014-09-26 14:58:51]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-09-26 14:59:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597783003/80001

[commit-bot: I haz the power, 2014-09-26 16:06:33]

Committed patchset #5 (id:80001) as 7a04a7c0a7421cb93f42dc3d88bf614d9371b292

[commit-bot: I haz the power, 2014-09-26 16:07:10]

Patchset 5 (id:??) landed as
https://crrev.com/3fce4e99a7b91b6ff5ea1036c4984f97e373ab76
Cr-Commit-Position: refs/heads/master@{#296954}