Remove incorrect isAcceleratedCompositingActive check

Remove incorrect isAcceleratedCompositingActive check

isAcceleratedCompositingActive is a racy check asking if the page has
had a compositing update with a non-null root layer.  This check in
WebTestProxy was added as a part of converting layout tests to force
compositing mode to make sure that any test asking for a readback was
going down the composited path rather than the legacy software path.

It should be possible to finish a test and ask for an asynchronous
readback prior to having done any compositing updates.  This check does
not seem legit in the first place, so just remove it.

BUG=397321
Committed: https://crrev.com/d82332795c3cf2bb42efe5a8b66e64d062b80ecb
Cr-Commit-Position: refs/heads/master@{#296450}

[enne (OOO), 2014-09-23 23:48:11]

enne@chromium.org changed reviewers:
+ dpranke@chromium.org

[loislo, 2014-09-24 13:03:12]

On 2014/09/24 05:00:41, enne_very_slow_to_review wrote:

there is another CHECK in DisplayAsyncThen

[danakj, 2014-09-24 14:27:37]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-09-24 14:27:38]

https://codereview.chromium.org/597773002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/597773002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:492: AnimateNow();
Can you also remove all these AnimateNow()s that were added to make the checks
not explode? Maybe once the blink side is fixed?

[Dirk Pranke, 2014-09-24 16:29:00]

owners lgtm once danakj is happy ...

[enne (OOO), 2014-09-24 16:44:55]

On 2014/09/24 at 13:03:12, loislo wrote:
> On 2014/09/24 05:00:41, enne_very_slow_to_review wrote:
> 
> there is another CHECK in DisplayAsyncThen

Done.

https://codereview.chromium.org/597773002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/597773002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:492: AnimateNow();
On 2014/09/24 14:27:38, danakj wrote:
> Can you also remove all these AnimateNow()s that were added to make the checks
> not explode? Maybe once the blink side is fixed?

I talked to loislo about this and am going to conservatively wait and remove it
next week.  I think there was a desire to make sure that the AnimateNow did
actually fix the flakiness even if the approach wasn't great, rather than
changing to an untested solution #2 really quickly.

[danakj, 2014-09-24 16:46:47]

ok. LGTM but let's keep the bug open to remove AnimateNow().

Can you add TODO on them to remove with pointer to the bug?

[enne (OOO), 2014-09-24 16:48:49]

On 2014/09/24 at 16:46:47, danakj wrote:

> Can you add TODO on them to remove with pointer to the bug?

Done.

[enne (OOO), 2014-09-24 16:48:59]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-09-24 16:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597773002/40001

[commit-bot: I haz the power, 2014-09-24 17:33:17]

Committed patchset #3 (id:40001) as 0b4b16f00349167b557dce7285a05da66520c1fc

[commit-bot: I haz the power, 2014-09-24 17:33:51]

Patchset 3 (id:??) landed as
https://crrev.com/d82332795c3cf2bb42efe5a8b66e64d062b80ecb
Cr-Commit-Position: refs/heads/master@{#296450}