content/browser/web_contents/web_contents_impl.h - Issue 597753003: Implement find in page support for top level BrowserPlugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 597753003: Implement find in page support for top level BrowserPlugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_embedder.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index c7a4e25ca4355643ce4298a151dcedcc9d8deeca..42072fd59d9bd003b607ae151846453735a833bf 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -692,6 +692,12 @@ class CONTENT_EXPORT WebContentsImpl

return video_power_save_blocker_;

}

+ void OnFindReply(int request_id,

+ int number_of_matches,

+ const gfx::Rect& selection_rect,

+ int active_match_ordinal,

+ bool final_update);

private:

friend class TestNavigationObserver;

friend class WebContentsAddedObserver;

@@ -791,11 +797,6 @@ class CONTENT_EXPORT WebContentsImpl

void OnUnregisterProtocolHandler(const std::string& protocol,

const GURL& url,

bool user_gesture);

- void OnFindReply(int request_id,

- int number_of_matches,

- const gfx::Rect& selection_rect,

- int active_match_ordinal,

- bool final_update);

#if defined(OS_ANDROID)

void OnFindMatchRectsReply(int version,

const std::vector<gfx::RectF>& rects,