Issue 59773005: Docserver: Fix a bug where undocumented APIs were being shown on the Private APIs page.

Issue 59773005: Docserver: Fix a bug where undocumented APIs were being shown on the Private APIs page. (Closed)

Created:
7 years, 1 month ago by dhnishi (use Chromium)

Modified:
7 years, 1 month ago

Reviewers:
dhnishi (use Chromium), not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Docserver: Fix a bug where undocumented APIs were being shown on the Private APIs page. NOTRY=true BUG=304839 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233156

Patch Set 2 : Moving the if statement. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	chrome/common/extensions/docs/server2/api_list_data_source.py	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/app.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dhnishi (use Chromium)

kalman: PTAL. The only API left on the page after the documentation check does in ...

7 years, 1 month ago (2013-11-05 21:16:07 UTC) #1

not at google - send to devlin

lgtm https://codereview.chromium.org/59773005/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): https://codereview.chromium.org/59773005/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode79 chrome/common/extensions/docs/server2/api_list_data_source.py:79: if api['name'] in documented_apis[platform]: move this up a ...

7 years, 1 month ago (2013-11-05 21:23:12 UTC) #2

dhnishi (use Chromium)

https://codereview.chromium.org/59773005/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): https://codereview.chromium.org/59773005/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode79 chrome/common/extensions/docs/server2/api_list_data_source.py:79: if api['name'] in documented_apis[platform]: On 2013/11/05 21:23:12, kalman wrote: ...

7 years, 1 month ago (2013-11-05 21:28:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/59773005/90001

7 years, 1 month ago (2013-11-05 21:49:28 UTC) #4

Message was sent while issue was closed.

Change committed as 233156

Expand Messages | Collapse Messages