Revert of ChromeOS: "Add New User" screen should enable all hardware keyboards.

Revert of ChromeOS: "Add New User" screen should enable all hardware keyboards. (patchset #14 id:260001 of https://codereview.chromium.org/484353005/)

Reason for revert:
Speculative, looks like this broke a bunch of browser_tests in dbg: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31837
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31837

Original issue's description:
> ChromeOS: "Add New User" screen should enable all hardware keyboards.
>
> "Add New User" screen should have enabled all hardware
> keyboards, owner and system input methods.
>
> BUG=365299
> TEST=manual
>
> Committed: https://crrev.com/a5a81ef618a26e513a4ae0f2b4b0e77f8224e946
> Cr-Commit-Position: refs/heads/master@{#296199}

TBR=dzhioev@chromium.org,shuchen@chromium.org,alemate@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365299
Committed: https://crrev.com/6f3fed9839e5bf2842165a919f3e7c1cd0795392
Cr-Commit-Position: refs/heads/master@{#296290}

[Nico, 2014-09-23 22:46:01]

Created Revert of ChromeOS: "Add New User" screen should enable all hardware
keyboards.

[commit-bot: I haz the power, 2014-09-23 22:48:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597723003/1

[commit-bot: I haz the power, 2014-09-23 22:50:36]

Committed patchset #1 (id:1) as e50ed2fd9cd1bb9d2c1614c4867d2175fec7ea26

[commit-bot: I haz the power, 2014-09-23 22:51:07]

Patchset 1 (id:??) landed as
https://crrev.com/6f3fed9839e5bf2842165a919f3e7c1cd0795392
Cr-Commit-Position: refs/heads/master@{#296290}

[Nico, 2014-09-24 15:35:27]

Looks like this revert helped.

On Tue, Sep 23, 2014 at 3:46 PM, <thakis@chromium.org> wrote:

> Reviewers: dzhioev, Shu Chen, Alexander Alekseev,
>
> Message:
> Created Revert of ChromeOS: "Add New User" screen should enable all
> hardware
> keyboards.
>
> Description:
> Revert of ChromeOS: "Add New User" screen should enable all hardware
> keyboards.
> (patchset #14 id:260001 of https://codereview.chromium.org/484353005/)
>
> Reason for revert:
> Speculative, looks like this broke a bunch of browser_tests in dbg:
> http://build.chromium.org/p/chromium.chromiumos/builders/
> Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31837
> http://build.chromium.org/p/chromium.chromiumos/builders/
> Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31837
>
> Original issue's description:
>
>> ChromeOS: "Add New User" screen should enable all hardware keyboards.
>>
>
>  "Add New User" screen should have enabled all hardware
>> keyboards, owner and system input methods.
>>
>
>  BUG=365299
>> TEST=manual
>>
>
>  Committed: https://crrev.com/a5a81ef618a26e513a4ae0f2b4b0e77f8224e946
>> Cr-Commit-Position: refs/heads/master@{#296199}
>>
>
> TBR=dzhioev@chromium.org,shuchen@chromium.org,alemate@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=365299
>
> Please review this at https://codereview.chromium.org/597723003/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+63, -457 lines):
>   M chrome/browser/chromeos/input_method/input_method_persistence.h
>   M chrome/browser/chromeos/input_method/input_method_persistence.cc
>   M chrome/browser/chromeos/login/login_manager_test.h
>   D chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc
>   M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
>   M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
>   M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
>   M chrome/chrome_tests.gypi
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexander Alekseev, 2014-09-24 15:42:04]

On 2014/09/24 15:35:27, Nico (hiding) wrote:
> Looks like this revert helped.

Yes, the revert was correct. I've uploaded fixed version.