Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 597713002: Move json schema compiler target into build/ to match gyp (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_wk_dep
Project:
chromium
Visibility:
Public.

Description

Move json schema compiler target into build/ to match gyp ui/ and chrome/ should not depend on anything from //extensions. R=brettw@chromium.org Committed: https://crrev.com/145636c494aa8b2ea39eb86f1b9c13f9ee52f3f7 Cr-Commit-Position: refs/heads/master@{#297528}

Patch Set 1 #

Total comments: 1

Patch Set 2 : json_schema_compile -> json_schema_api #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -220 lines) Patch
A + build/json_schema_api.gni View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/json_schema_bundle_registration_compile.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/json_schema_compile.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D extensions/generated_extensions_api.gni View 1 2 1 chunk +0 lines, -209 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jamesr
6 years, 3 months ago (2014-09-23 21:10:03 UTC) #1
brettw
Too bad, I liked it in extensions... https://codereview.chromium.org/597713002/diff/1/ui/accessibility/BUILD.gn File ui/accessibility/BUILD.gn (right): https://codereview.chromium.org/597713002/diff/1/ui/accessibility/BUILD.gn#newcode74 ui/accessibility/BUILD.gn:74: json_schema_compile("ax_gen") { ...
6 years, 3 months ago (2014-09-23 21:42:57 UTC) #2
jamesr
Sure, PTAL
6 years, 3 months ago (2014-09-24 00:23:40 UTC) #3
brettw
lgtm
6 years, 3 months ago (2014-09-24 00:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597713002/60001
6 years, 2 months ago (2014-09-29 22:23:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14236)
6 years, 2 months ago (2014-09-29 22:32:59 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/145636c494aa8b2ea39eb86f1b9c13f9ee52f3f7 Cr-Commit-Position: refs/heads/master@{#297528}
6 years, 2 months ago (2014-09-30 22:28:16 UTC) #9
jamesr
6 years, 2 months ago (2014-09-30 22:28:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
145636c494aa8b2ea39eb86f1b9c13f9ee52f3f7.

Powered by Google App Engine
This is Rietveld 408576698