ash/wm/dock/docked_window_layout_manager_unittest.cc - Issue 597683003: Add window states docked; and docked minimized. Add wm window event to set docked and undocked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/dock/docked_window_layout_manager_unittest.cc

Issue 597683003: Add window states docked; and docked minimized. Add wm window event to set docked and undocked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dock

Patch Set: Address Restore of App Windows and DockLeft/Dock Right issues Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/dock/docked_window_layout_manager.cc ('K') | « ash/wm/dock/docked_window_layout_manager.cc ('k') | ash/wm/dock/docked_window_resizer.cc » ('j') | ash/wm/dock/docked_window_resizer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/dock/docked_window_layout_manager_unittest.cc

diff --git a/ash/wm/dock/docked_window_layout_manager_unittest.cc b/ash/wm/dock/docked_window_layout_manager_unittest.cc

index a8054a39b9a768f44632e40e1b16ddc5e866765f..16134a3431b2e2638ba20d730b3221fa95344e15 100644

--- a/ash/wm/dock/docked_window_layout_manager_unittest.cc

+++ b/ash/wm/dock/docked_window_layout_manager_unittest.cc

@@ -710,8 +710,11 @@ TEST_P(DockedWindowLayoutManagerTest, ThreeWindowsMinimize) {

// The first window should get minimized but parented by the dock container.

EXPECT_TRUE(wm::GetWindowState(w1.get())->IsMinimized());

- EXPECT_TRUE(wm::GetWindowState(w2.get())->IsNormalStateType());

- EXPECT_TRUE(wm::GetWindowState(w3.get())->IsNormalStateType());

+ EXPECT_TRUE(wm::GetWindowState(w1.get())->IsDocked());

+ EXPECT_FALSE(wm::GetWindowState(w2.get())->IsMinimized());

+ EXPECT_TRUE(wm::GetWindowState(w2.get())->IsDocked());

+ EXPECT_FALSE(wm::GetWindowState(w3.get())->IsMinimized());

+ EXPECT_TRUE(wm::GetWindowState(w3.get())->IsDocked());

EXPECT_EQ(kShellWindowId_DockedContainer, w1->parent()->id());

}