Add window states docked; and docked minimized. Add wm window event to set docked and undocked.

ash/wm/dock/docked_window_layout_manager.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_
 #define ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_
 
 #include "ash/ash_export.h"
 #include "ash/shelf/shelf_layout_manager_observer.h"
 #include "ash/shell_observer.h"
@@ skipping 89 matching lines @@
   void DockDraggedWindow(aura::Window* window);
 
   // Called by a DockedWindowResizer when a dragged window is no longer docked.
   void UndockDraggedWindow();
 
   // Called by a DockedWindowResizer when a window is no longer being dragged.
   // Stops observing the window unless it is a child.
   // Records |action| by |source| in UMA.
   void FinishDragging(DockedAction action, DockedActionSource source);
 
+  void SetDockedAlignment(DockedAlignment desired_alignment);

[varkha, 2014/09/29 18:59:28]

nit: Not sure if Set is the right name here since this is not a simple setter.
Also needs a comment describing the parameter(s).

[dtapuska, 2014/09/29 20:59:57]

Done.

+
   Shelf* shelf() { return shelf_; }
   void SetShelf(Shelf* shelf);
 
   // Calculates if a window is touching the screen edges and returns edge.
   DockedAlignment GetAlignmentOfWindow(const aura::Window* window) const;
 
   // Used to snap docked windows to the side of screen during drag.
   DockedAlignment CalculateAlignment() const;
 
   // Returns true when a window can be docked. Windows cannot be docked at the
@@ skipping 56 matching lines @@
   class ShelfWindowObserver;
   friend class DockedWindowLayoutManagerTest;
   friend class DockedWindowResizerTest;
 
   // Width of the gap between the docked windows and a workspace.
   static const int kMinDockGap;
 
   // Ideal (starting) width of the dock.
   static const int kIdealWidth;
 
+  DockedAlignment CalculateAlignment(const aura::Window* query_window) const;

[varkha, 2014/09/29 18:59:28]

CalculateAlignment name is already used and is public. I would make the name
explicit, maybe CalculateAlignmentOfWindow(window) and change the parameter to
just |window|. Also needs a comment explaining what it returns and the
parameter(s).

[dtapuska, 2014/09/29 20:59:57]

Done.

+
   // Keep at most kMaxVisibleWindows visible in the dock and minimize the rest
   // (except for |child|).
   void MaybeMinimizeChildrenExcept(aura::Window* child);
 
   // Minimize / restore window and relayout.
   void MinimizeDockedWindow(wm::WindowState* window_state);
   void RestoreDockedWindow(wm::WindowState* window_state);
 
   // Record user-initiated |action| by |source| in UMA metrics.
   void RecordUmaAction(DockedAction action, DockedActionSource source);
@@ skipping 107 matching lines @@
 
   // Observers of dock bounds changes.
   ObserverList<DockedWindowLayoutManagerObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(DockedWindowLayoutManager);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_