Add window states docked; and docked minimized. Add wm window event to set docked and undocked.

ash/wm/dock/docked_window_layout_manager.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_
 #define ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_
 
 #include "ash/ash_export.h"
 #include "ash/shelf/shelf_layout_manager_observer.h"
 #include "ash/shell_observer.h"
@@ skipping 89 matching lines @@
   void DockDraggedWindow(aura::Window* window);
 
   // Called by a DockedWindowResizer when a dragged window is no longer docked.
   void UndockDraggedWindow();
 
   // Called by a DockedWindowResizer when a window is no longer being dragged.
   // Stops observing the window unless it is a child.
   // Records |action| by |source| in UMA.
   void FinishDragging(DockedAction action, DockedActionSource source);
 
+  // Request the desired dock alignment. The alginment adjustment may not
+  // be applied as it may not be available; for example if the shelf
+  // is in the requested place; the transformation won't be applied.
+  void RequestDesiredDockedAlignment(DockedAlignment desired_alignment);

[varkha, 2014/09/30 20:15:21]

From the comment sounds like MaybeSetDesiredDockedAlignment. The comments are
usually written describing what the method does ("Sets...", "Allocates...",
"Calculates...", etc). So in this case it could be "Checks the rules and
possibly updates the docked layout to conform to |desired_alignment|. May not
apply the |desired_alignment| when current shelf alignment conflicts with it.
Never clears the |alignment_|."

[dtapuska, 2014/10/01 15:01:34]

Done.

+
   Shelf* shelf() { return shelf_; }
   void SetShelf(Shelf* shelf);
 
   // Calculates if a window is touching the screen edges and returns edge.
   DockedAlignment GetAlignmentOfWindow(const aura::Window* window) const;
 
   // Used to snap docked windows to the side of screen during drag.
   DockedAlignment CalculateAlignment() const;
 
   // Returns true when a window can be docked. Windows cannot be docked at the
@@ skipping 56 matching lines @@
   class ShelfWindowObserver;
   friend class DockedWindowLayoutManagerTest;
   friend class DockedWindowResizerTest;
 
   // Width of the gap between the docked windows and a workspace.
   static const int kMinDockGap;
 
   // Ideal (starting) width of the dock.
   static const int kIdealWidth;
 
+  // Calculate the alignment of the dock; the children need to be traversed;
+  // and the |child| should be skipped in the calculation. The computed dock
+  // alignment is returned.
+  DockedAlignment CalculateDockedAlignmentExcept(const aura::Window* child)

[varkha, 2014/09/30 20:15:19]

nit: How about CalculateAlignmentExcept?
nit: Calculates...
nit: Avoid passive (e.g. "Returns alignment of docked windows other than the
|child|.")

[dtapuska, 2014/10/01 15:01:34]

Done.

+      const;
+
+  // Determine if the |desired_alignment| is applicable taking into account

[varkha, 2014/09/30 20:15:21]

I think this is IsDockedAlignmentValid.
nits:
s/desired_alignment/alignment
s/Determine/Determines.
s/location of the shelf/shelf alignment.

[dtapuska, 2014/10/01 15:01:34]

Done.

+  // the location of the shelf.
+  bool IsDockedAlignmentApplicable(DockedAlignment desired_alignment) const;
+
   // Keep at most kMaxVisibleWindows visible in the dock and minimize the rest
   // (except for |child|).
   void MaybeMinimizeChildrenExcept(aura::Window* child);
 
   // Minimize / restore window and relayout.
   void MinimizeDockedWindow(wm::WindowState* window_state);
   void RestoreDockedWindow(wm::WindowState* window_state);
 
   // Record user-initiated |action| by |source| in UMA metrics.
   void RecordUmaAction(DockedAction action, DockedActionSource source);
@@ skipping 107 matching lines @@
 
   // Observers of dock bounds changes.
   ObserverList<DockedWindowLayoutManagerObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(DockedWindowLayoutManager);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_DOCK_DOCKED_WINDOW_LAYOUT_MANAGER_H_