Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 597683002: Copy LatencyInfo from renderer into corresponding Surface. (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy LatencyInfo from renderer into corresponding Surface. This was being dropped on the floor. Committed: https://crrev.com/2340a8b517629e460dec10d4c6cf3e9b2770fea2 Cr-Commit-Position: refs/heads/master@{#296260}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/compositor/delegated_frame_host.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbauman
6 years, 3 months ago (2014-09-23 19:36:23 UTC) #2
danakj
https://codereview.chromium.org/597683002/diff/1/content/browser/compositor/delegated_frame_host.cc File content/browser/compositor/delegated_frame_host.cc (right): https://codereview.chromium.org/597683002/diff/1/content/browser/compositor/delegated_frame_host.cc#newcode397 content/browser/compositor/delegated_frame_host.cc:397: compositor_frame->metadata.latency_info.push_back(*it); can you use compositor_frame->metadata.latency_info.insert(latency_info.begin(), latency_info.end().. ) to make ...
6 years, 3 months ago (2014-09-23 19:48:27 UTC) #3
jbauman
PTAL. https://codereview.chromium.org/597683002/diff/1/content/browser/compositor/delegated_frame_host.cc File content/browser/compositor/delegated_frame_host.cc (right): https://codereview.chromium.org/597683002/diff/1/content/browser/compositor/delegated_frame_host.cc#newcode397 content/browser/compositor/delegated_frame_host.cc:397: compositor_frame->metadata.latency_info.push_back(*it); On 2014/09/23 19:48:27, danakj wrote: > can ...
6 years, 3 months ago (2014-09-23 19:57:25 UTC) #4
danakj
LGTM!
6 years, 3 months ago (2014-09-23 19:58:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597683002/20001
6 years, 3 months ago (2014-09-23 20:31:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c5a62db3d3f9499f06fd0d805cff75872438b796
6 years, 3 months ago (2014-09-23 21:43:01 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:43:51 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2340a8b517629e460dec10d4c6cf3e9b2770fea2
Cr-Commit-Position: refs/heads/master@{#296260}

Powered by Google App Engine
This is Rietveld 408576698