Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 597653002: Make extension APIs work in MimeHandlerView. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@work-pdf-zoom2-dbg
Project:
chromium
Visibility:
Public.

Description

Make extension APIs work in MimeHandlerView. This will make some zoom functionality work in pdf viewer as they rely on tabs.setZoomSettings/tabs.setZoom. BUG=416332 Test=Load chrome with --enable-mime-handler-view and --out-of-process-pdf Navigate to a pdf file, see ctrl+/- or zooming through browser menu work. Ctrl + wheel still doesn't work, will fix that in a follow up CL. Committed: https://crrev.com/d610be6f1c292e500100f6a3579673add6b5905f Cr-Commit-Position: refs/heads/master@{#296295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 2 chunks +13 lines, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 4 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lazyboy
6 years, 3 months ago (2014-09-23 17:33:53 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-23 17:38:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597653002/1
6 years, 3 months ago (2014-09-23 20:31:45 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-23 22:36:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597653002/1
6 years, 3 months ago (2014-09-23 23:01:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 41700b20e83cebe7a7b81884d63078e8628eb500
6 years, 3 months ago (2014-09-23 23:17:58 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 23:18:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d610be6f1c292e500100f6a3579673add6b5905f
Cr-Commit-Position: refs/heads/master@{#296295}

Powered by Google App Engine
This is Rietveld 408576698