Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 59763014: DPCHECK known conditions when we guess false in CurrentProcessHasOpenDirectories (Closed)

Created:
7 years, 1 month ago by Mostyn Bramley-Moore
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Visibility:
Public.

Description

DPCHECK known conditions when we guess false in CurrentProcessHasOpenDirectories openat(AT_FDCWD, "/proc/self/fd", ...) can fail if we have been chrooted (eg into /proc/self/fdinfo) without directory listing permissions on the new root dir (hence EACCES). And even if we did have this permission, /proc wouldn't exist (hence ENOENT). TEST=Make a debug build or a release build with dcheck_always_on=1 and verify that this DPCHECK does not fail. BUG=314985 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237766

Patch Set 1 #

Patch Set 2 : update to newer master (and fix typo) #

Patch Set 3 : trying to work around a rietveld bug(?) #

Total comments: 2

Patch Set 4 : CHECK -> DPCHECK #

Patch Set 5 : update on newer master again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M sandbox/linux/services/credentials.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@jln: PTAL
7 years, 1 month ago (2013-11-17 13:52:12 UTC) #1
Mostyn Bramley-Moore
@jln: *ping*
7 years ago (2013-11-27 12:29:37 UTC) #2
jln (very slow on Chromium)
On 2013/11/27 12:29:37, Mostyn Bramley-Moore wrote: > @jln: *ping* Arg, I'm a horrible person, sorry ...
7 years ago (2013-11-27 21:23:52 UTC) #3
jln (very slow on Chromium)
https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/credentials.cc File sandbox/linux/services/credentials.cc (right): https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/credentials.cc#newcode170 sandbox/linux/services/credentials.cc:170: CHECK(errno == EACCES || errno == ENOENT); Do you ...
7 years ago (2013-11-27 21:26:15 UTC) #4
Mostyn Bramley-Moore
https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/credentials.cc File sandbox/linux/services/credentials.cc (right): https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/credentials.cc#newcode170 sandbox/linux/services/credentials.cc:170: CHECK(errno == EACCES || errno == ENOENT); On 2013/11/27 ...
7 years ago (2013-11-28 09:35:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/59763014/100001
7 years ago (2013-11-28 09:36:43 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-11-28 12:05:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/59763014/100001
7 years ago (2013-11-28 12:08:01 UTC) #8
commit-bot: I haz the power
7 years ago (2013-11-28 12:58:53 UTC) #9
Message was sent while issue was closed.
Change committed as 237766

Powered by Google App Engine
This is Rietveld 408576698