DPCHECK known conditions when we guess false in CurrentProcessHasOpenDirectories

DPCHECK known conditions when we guess false in CurrentProcessHasOpenDirectories

openat(AT_FDCWD, "/proc/self/fd", ...) can fail if we have been chrooted
(eg into /proc/self/fdinfo) without directory listing permissions on the
new root dir (hence EACCES).  And even if we did have this permission,
/proc wouldn't exist (hence ENOENT).

TEST=Make a debug build or a release build with dcheck_always_on=1 and verify that this DPCHECK does not fail.

BUG=314985
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237766

[Mostyn Bramley-Moore, 2013-11-17 13:52:12]

@jln: PTAL

[Mostyn Bramley-Moore, 2013-11-27 12:29:37]

@jln: *ping*

[jln (very slow on Chromium), 2013-11-27 21:23:52]

On 2013/11/27 12:29:37, Mostyn Bramley-Moore wrote:
> @jln: *ping*

Arg, I'm a horrible person, sorry for the delay Mostyn.

lgtm

[jln (very slow on Chromium), 2013-11-27 21:26:15]

https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/cr...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/cr...
sandbox/linux/services/credentials.cc:170: CHECK(errno == EACCES || errno ==
ENOENT);
Do you want to make this a DPCHECK instead?

DCHECK is good enough for this purpose and printing errno will be useful.

[Mostyn Bramley-Moore, 2013-11-28 09:35:31]

https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/cr...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/59763014/diff/60001/sandbox/linux/services/cr...
sandbox/linux/services/credentials.cc:170: CHECK(errno == EACCES || errno ==
ENOENT);
On 2013/11/27 21:26:15, jln wrote:
> Do you want to make this a DPCHECK instead?
> 
> DCHECK is good enough for this purpose and printing errno will be useful.

Done.

[commit-bot: I haz the power, 2013-11-28 09:36:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/59763014/100001

[commit-bot: I haz the power, 2013-11-28 12:05:17]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-11-28 12:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/59763014/100001

[commit-bot: I haz the power, 2013-11-28 12:58:53]

Change committed as 237766