Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1922)

Issue 59763011: Remove 'FAST_MOBILE_SCROLLING' (Closed)

Created:
7 years, 1 month ago by atreat
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, jchaffraix+rendering, Peter Beverloo, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove feature that is no longer used by blink as the Android port now turns fixed backgrounds into layers rendering this code obsolete. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161821

Patch Set 1 #

Patch Set 2 : Remove FAST_MOBILE_SCROLLING altogether #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M Source/build/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
atreat
As discussed on IRC this patch turns FAST_MOBILE_SCROLLING into a runtime enabled feature.
7 years, 1 month ago (2013-11-06 17:46:11 UTC) #1
atreat
Adding Peter and Laszlo who might be interested.
7 years, 1 month ago (2013-11-06 17:47:04 UTC) #2
atreat
This feature is turned on by android via a chromium CL: https://codereview.chromium.org/62413002/
7 years, 1 month ago (2013-11-06 17:47:52 UTC) #3
Peter Beverloo
+Sami We turn backgrounds with background-attachment:fixed into layers, which make them work just fine on ...
7 years, 1 month ago (2013-11-07 14:05:17 UTC) #4
atreat
New version that removes this compile flag altogether as it is unnecessary since Android uses ...
7 years, 1 month ago (2013-11-11 19:25:26 UTC) #5
abarth-chromium
Great! LGTM
7 years, 1 month ago (2013-11-11 21:50:34 UTC) #6
Peter Beverloo
lgtm, thank you!
7 years, 1 month ago (2013-11-12 13:47:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/59763011/60001
7 years, 1 month ago (2013-11-12 15:10:51 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 16:14:46 UTC) #9
Message was sent while issue was closed.
Change committed as 161821

Powered by Google App Engine
This is Rietveld 408576698