Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 59763010: Speed up typed array constructors. (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Speed up typed array constructors. - Avoid calls into ToPositiveInteger for valid cases of 'undefined' arguments. (Otherwise it calls into runtime). - Reduce the checks performed in case offset for TypedArrayFromArrayBuffer constructor is called with no offset argument. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17567

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/typedarray.js View 3 chunks +17 lines, -10 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL. That's the end of low-hanging fruit in typed array constructors + preparations to more ...
7 years, 1 month ago (2013-11-06 16:44:12 UTC) #1
Yang
LGTM. https://codereview.chromium.org/59763010/diff/1/src/typedarray.js File src/typedarray.js (right): https://codereview.chromium.org/59763010/diff/1/src/typedarray.js#newcode311 src/typedarray.js:311: 0 : ToPositiveInteger(byteOffset, 'invalid_data_view_offset'); I think we use ...
7 years, 1 month ago (2013-11-07 10:14:11 UTC) #2
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-07 14:56:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17567 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698