Issue 59763002: Fix GetPairedOutputParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59763002: Fix GetPairedOutputParameters (Closed)

Created:
7 years, 1 month ago by tommi (sloooow) - chröme

Modified:
7 years, 1 month ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix GetPairedOutputParameters to not set any of the output parameters unless all of them are valid. Before we could set e.g. the session_id but return false. BUG=315051 R=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232975

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	content/renderer/media/webrtc_audio_capturer.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

On 2013/11/05 12:27:49, tommi wrote: lgtm

7 years, 1 month ago (2013-11-05 13:18:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/59763002/1

7 years, 1 month ago (2013-11-05 13:18:50 UTC) #3

tommi (sloooow) - chröme

7 years, 1 month ago (2013-11-05 14:11:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r232975 (presubmit successful).

Expand Messages | Collapse Messages