Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 597603003: Open continue url from gaia incognito header (Closed)

Created:
6 years, 3 months ago by guohui
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Open continue url from gaia incognito header BUG=414247 Committed: https://crrev.com/b93356a002e8af82973b60c3ad44e84bcae53f91 Cr-Commit-Position: refs/heads/master@{#296495}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed addsession #

Patch Set 3 : url-decode header value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/signin/signin_header_helper.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 3 months ago (2014-09-23 20:07:04 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/597603003/diff/1/chrome/browser/signin/signin_header_helper.cc File chrome/browser/signin/signin_header_helper.cc (right): https://codereview.chromium.org/597603003/diff/1/chrome/browser/signin/signin_header_helper.cc#newcode143 chrome/browser/signin/signin_header_helper.cc:143: bubble_mode = BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN; While you're here, fix this ...
6 years, 3 months ago (2014-09-24 00:59:18 UTC) #3
guohui
https://codereview.chromium.org/597603003/diff/1/chrome/browser/signin/signin_header_helper.cc File chrome/browser/signin/signin_header_helper.cc (right): https://codereview.chromium.org/597603003/diff/1/chrome/browser/signin/signin_header_helper.cc#newcode143 chrome/browser/signin/signin_header_helper.cc:143: bubble_mode = BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN; On 2014/09/24 00:59:18, Roger Tawa wrote: ...
6 years, 3 months ago (2014-09-24 18:16:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597603003/20001
6 years, 3 months ago (2014-09-24 18:17:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597603003/40001
6 years, 3 months ago (2014-09-24 19:11:24 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3a3081be22408521503b573954a44d7b7c200a77
6 years, 3 months ago (2014-09-24 20:01:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 20:02:04 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b93356a002e8af82973b60c3ad44e84bcae53f91
Cr-Commit-Position: refs/heads/master@{#296495}

Powered by Google App Engine
This is Rietveld 408576698