Add a SupervisedUserServiceObserver.

chrome/browser/supervised_user/supervised_user_interstitial.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/supervised_user/supervised_user_interstitial.h"
 
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 93 matching lines @@
   if (!interstitial->Init())
     delete interstitial;
   // Otherwise |interstitial_page_| is responsible for deleting it.
 }
 
 SupervisedUserInterstitial::SupervisedUserInterstitial(
     WebContents* web_contents,
     const GURL& url,
     const base::Callback<void(bool)>& callback)
     : web_contents_(web_contents),
+      profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
       interstitial_page_(NULL),
       url_(url),
       callback_(callback) {}
 
-SupervisedUserInterstitial::~SupervisedUserInterstitial() {}
+SupervisedUserInterstitial::~SupervisedUserInterstitial() {
+  DCHECK(!web_contents_);
+}
 
 bool SupervisedUserInterstitial::Init() {
   if (ShouldProceed()) {
     // It can happen that the site was only allowed very recently and the URL
     // filter on the IO thread had not been updated yet. Proceed with the
     // request without showing the interstitial.
     DispatchContinueRequest(true);
     return false;
   }
 
@@ skipping 16 matching lines @@
     details.type = content::NAVIGATION_TYPE_NEW_PAGE;
     for (int i = service->infobar_count() - 1; i >= 0; --i) {
       infobars::InfoBar* infobar = service->infobar_at(i);
       if (infobar->delegate()->ShouldExpire(
               InfoBarService::NavigationDetailsFromLoadCommittedDetails(
                   details)))
         service->RemoveInfoBar(infobar);
     }
   }
 
-  // TODO(bauerb): Extract an observer callback on SupervisedUserService for
-  // this.
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents_->GetBrowserContext());
-  PrefService* prefs = profile->GetPrefs();
-  pref_change_registrar_.Init(prefs);
-  pref_change_registrar_.Add(
-      prefs::kDefaultSupervisedUserFilteringBehavior,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
-  pref_change_registrar_.Add(
-      prefs::kSupervisedUserManualHosts,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
-  pref_change_registrar_.Add(
-      prefs::kSupervisedUserManualURLs,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
+  SupervisedUserService* supervised_user_service =
+      SupervisedUserServiceFactory::GetForProfile(profile_);
+  supervised_user_service->AddObserver(this);
 
   interstitial_page_ =
       content::InterstitialPage::Create(web_contents_, true, url_, this);
   interstitial_page_->Show();
 
   return true;
 }
 
 std::string SupervisedUserInterstitial::GetHTMLContents() {
   base::DictionaryValue strings;
   strings.SetString("blockPageTitle",
                     l10n_util::GetStringUTF16(IDS_BLOCK_INTERSTITIAL_TITLE));
 
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   SupervisedUserService* supervised_user_service =
-      SupervisedUserServiceFactory::GetForProfile(profile);
+      SupervisedUserServiceFactory::GetForProfile(profile_);
 
   bool allow_access_requests = supervised_user_service->AccessRequestsEnabled();
   strings.SetBoolean("allowAccessRequests", allow_access_requests);
 
-  std::string profile_image_url = profile->GetPrefs()->GetString(
+  std::string profile_image_url = profile_->GetPrefs()->GetString(
       prefs::kSupervisedUserCustodianProfileImageURL);
   strings.SetString("avatarURL1x", BuildAvatarImageUrl(profile_image_url,
                                                        kAvatarSize1x));
   strings.SetString("avatarURL2x", BuildAvatarImageUrl(profile_image_url,
                                                        kAvatarSize2x));
 
-  std::string profile_image_url2 = profile->GetPrefs()->GetString(
+  std::string profile_image_url2 = profile_->GetPrefs()->GetString(
       prefs::kSupervisedUserSecondCustodianProfileImageURL);
   strings.SetString("secondAvatarURL1x", BuildAvatarImageUrl(profile_image_url2,
                                                              kAvatarSize1x));
   strings.SetString("secondAvatarURL2x", BuildAvatarImageUrl(profile_image_url2,
                                                              kAvatarSize2x));
 
   base::string16 custodian =
       base::UTF8ToUTF16(supervised_user_service->GetCustodianName());
   strings.SetString(
       "blockPageMessage",
@@ skipping 44 matching lines @@
 
     interstitial_page_->DontProceed();
     return;
   }
 
   if (command == "\"request\"") {
     UMA_HISTOGRAM_ENUMERATION("ManagedMode.BlockingInterstitialCommand",
                               ACCESS_REQUEST,
                               HISTOGRAM_BOUNDING_VALUE);
 
-    Profile* profile =
-        Profile::FromBrowserContext(web_contents_->GetBrowserContext());
     SupervisedUserService* supervised_user_service =
-        SupervisedUserServiceFactory::GetForProfile(profile);
+        SupervisedUserServiceFactory::GetForProfile(profile_);
     supervised_user_service->AddAccessRequest(url_);
     DVLOG(1) << "Sent access request for " << url_.spec();
 
     return;
   }
 
   NOTREACHED();
 }
 
 void SupervisedUserInterstitial::OnProceed() {
   // CHECK instead of DCHECK as defense in depth in case we'd accidentally
   // proceed on a blocked page.
   CHECK(ShouldProceed());
   DispatchContinueRequest(true);
 }
 
 void SupervisedUserInterstitial::OnDontProceed() {
   DispatchContinueRequest(false);
 }
 
+void SupervisedUserInterstitial::OnURLFilterChanged() {
+  if (ShouldProceed())
+    interstitial_page_->Proceed();
+}
+
 bool SupervisedUserInterstitial::ShouldProceed() {
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   SupervisedUserService* supervised_user_service =
-      SupervisedUserServiceFactory::GetForProfile(profile);
+      SupervisedUserServiceFactory::GetForProfile(profile_);
   SupervisedUserURLFilter* url_filter =
       supervised_user_service->GetURLFilterForUIThread();
   return url_filter->GetFilteringBehaviorForURL(url_) !=
          SupervisedUserURLFilter::BLOCK;
 }
 
-void SupervisedUserInterstitial::OnFilteringPrefsChanged() {
-  if (ShouldProceed())
-    interstitial_page_->Proceed();
-}
-
 void SupervisedUserInterstitial::DispatchContinueRequest(
     bool continue_request) {
+  SupervisedUserService* supervised_user_service =
+      SupervisedUserServiceFactory::GetForProfile(profile_);
+  supervised_user_service->RemoveObserver(this);
+
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE, base::Bind(callback_, continue_request));
+
+  // After this, the WebContents may be destroyed. Make sure we don't try to use
+  // it again.
+  web_contents_ = NULL;
 }