Add a SupervisedUserServiceObserver.

chrome/browser/supervised_user/supervised_user_interstitial.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/supervised_user/supervised_user_interstitial.h"
 
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 97 matching lines @@
 
 SupervisedUserInterstitial::SupervisedUserInterstitial(
     WebContents* web_contents,
     const GURL& url,
     const base::Callback<void(bool)>& callback)
     : web_contents_(web_contents),
       interstitial_page_(NULL),
       url_(url),
       callback_(callback) {}
 
-SupervisedUserInterstitial::~SupervisedUserInterstitial() {}
+SupervisedUserInterstitial::~SupervisedUserInterstitial() {
+  DCHECK(!web_contents_);
+}
 
 bool SupervisedUserInterstitial::Init() {
   if (ShouldProceed()) {
     // It can happen that the site was only allowed very recently and the URL
     // filter on the IO thread had not been updated yet. Proceed with the
     // request without showing the interstitial.
     DispatchContinueRequest(true);
     return false;
   }
 
@@ skipping 16 matching lines @@
     details.type = content::NAVIGATION_TYPE_NEW_PAGE;
     for (int i = service->infobar_count() - 1; i >= 0; --i) {
       infobars::InfoBar* infobar = service->infobar_at(i);
       if (infobar->delegate()->ShouldExpire(
               InfoBarService::NavigationDetailsFromLoadCommittedDetails(
                   details)))
         service->RemoveInfoBar(infobar);
     }
   }
 
-  // TODO(bauerb): Extract an observer callback on SupervisedUserService for
-  // this.
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
-  PrefService* prefs = profile->GetPrefs();
-  pref_change_registrar_.Init(prefs);
-  pref_change_registrar_.Add(
-      prefs::kDefaultSupervisedUserFilteringBehavior,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
-  pref_change_registrar_.Add(
-      prefs::kSupervisedUserManualHosts,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
-  pref_change_registrar_.Add(
-      prefs::kSupervisedUserManualURLs,
-      base::Bind(&SupervisedUserInterstitial::OnFilteringPrefsChanged,
-                 base::Unretained(this)));
+  SupervisedUserService* supervised_user_service =
+      SupervisedUserServiceFactory::GetForProfile(profile);
+  supervised_user_service->AddObserver(this);
 
   interstitial_page_ =
       content::InterstitialPage::Create(web_contents_, true, url_, this);
   interstitial_page_->Show();
 
   return true;
 }
 
 std::string SupervisedUserInterstitial::GetHTMLContents() {
   base::DictionaryValue strings;
@@ skipping 97 matching lines @@
   // CHECK instead of DCHECK as defense in depth in case we'd accidentally
   // proceed on a blocked page.
   CHECK(ShouldProceed());
   DispatchContinueRequest(true);
 }
 
 void SupervisedUserInterstitial::OnDontProceed() {
   DispatchContinueRequest(false);
 }
 
+void SupervisedUserInterstitial::OnURLFilterChanged() {
+  if (web_contents_ && ShouldProceed())

[Bernhard Bauer, 2014/09/24 11:51:59]

Why do we need the |web_contents_| check now? Just because we need the
|web_contents_| to get the profile from it, to unregister ourselves from the
SUService?

[Marc Treib, 2014/09/24 12:02:27]

Because ShouldProceed uses the WebContents to get the Profile->SUService to
check the URLFilter. If we outlive the WebContents, that won't work. I guess we
could also cache a Profile*, but in this case it doesn't matter anyway.

+    interstitial_page_->Proceed();
+}
+
 bool SupervisedUserInterstitial::ShouldProceed() {
+  DCHECK(web_contents_);
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   SupervisedUserService* supervised_user_service =
       SupervisedUserServiceFactory::GetForProfile(profile);
   SupervisedUserURLFilter* url_filter =
       supervised_user_service->GetURLFilterForUIThread();
   return url_filter->GetFilteringBehaviorForURL(url_) !=
          SupervisedUserURLFilter::BLOCK;
 }
 
-void SupervisedUserInterstitial::OnFilteringPrefsChanged() {
-  if (ShouldProceed())
-    interstitial_page_->Proceed();
-}
-
 void SupervisedUserInterstitial::DispatchContinueRequest(
     bool continue_request) {
+  DCHECK(web_contents_);
+  Profile* profile =
+      Profile::FromBrowserContext(web_contents_->GetBrowserContext());
+  SupervisedUserService* supervised_user_service =
+      SupervisedUserServiceFactory::GetForProfile(profile);
+  supervised_user_service->RemoveObserver(this);
+
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE, base::Bind(callback_, continue_request));
+
+  // After this, the WebContents may be destroyed. Make sure we don't try to use
+  // it again.
+  web_contents_ = NULL;

[Bernhard Bauer, 2014/09/24 11:51:59]

Is it guaranteed that this will be called, even if e.g. the tab/window is
closed?

Also, under what circumstances does the interstitial actually outlive the
WebContents?

[Marc Treib, 2014/09/24 12:02:27]

Yes, InterstitialPageImpl calls OnDontProceed when the tab/window is closed.
Apparently, we (almost?) always outlive the WebContents - the order of
destruction is a bit weird here. See InterstitialPageImpl::WebContentsDestroyed,
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/fr...

[Bernhard Bauer, 2014/09/24 12:58:43]

Hm, accessing |web_contents_| above already worries me... WebContentsDestroyed()
is called from the WebContentsImpl destructor, so we're calling into a partially
destroyed WebContents.

I think caching the Profile instead would be much easier, as it's guaranteed
that that will outlive us. That would also get rid of the additional
|web_contents_| check in OnURLFilterChanged().

[Marc Treib, 2014/09/24 13:25:25]

That's a good point.
Done.

 }