Fix crash which occurs when combining AthenaTestBase tests and other tests

athena/main/athena_views_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/main/athena_views_delegate.h"
 
 #include "athena/main/athena_frame_view.h"
 #include "athena/screen/public/screen_manager.h"
+#include "ui/views/views_delegate.h"
 
 namespace athena {
 
-void AthenaViewsDelegate::OnBeforeWidgetInit(
-    views::Widget::InitParams* params,
-    views::internal::NativeWidgetDelegate* delegate) {
-  params->context = athena::ScreenManager::Get()->GetContext();
+namespace {
+
+class AthenaViewsDelegateImpl : public AthenaViewsDelegate,

[oshima, 2014/09/23 20:35:53]

and you don't have to extend AthenaViewsDelegate. 

I'm ok for AthenaViewsDelegate being just an interface to create/shutdown
AthenaViewsDelegateImpl class. 

[pkotwicz, 2014/09/23 20:44:38]

Oshima, do you think that it is worth AthenaViewsDelegate being a class?

We could have two functions:
CreateAthenaViewsDelegate()
ShutdownAthenaViewsDelegate()

[oshima, 2014/09/23 20:49:56]

SGTM

+                                public views::ViewsDelegate {
+ public:
+  AthenaViewsDelegateImpl() {
+  }
+
+  virtual ~AthenaViewsDelegateImpl() {
+  }
+
+  virtual void OnBeforeWidgetInit(
+      views::Widget::InitParams* params,
+      views::internal::NativeWidgetDelegate* delegate) OVERRIDE {
+    params->context = athena::ScreenManager::Get()->GetContext();
+  }
+
+  virtual views::NonClientFrameView* CreateDefaultNonClientFrameView(
+      views::Widget* widget) OVERRIDE {
+    return new AthenaFrameView(widget);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AthenaViewsDelegateImpl);
+};
+
+}  // namespace
+
+// static
+views::ViewsDelegate* AthenaViewsDelegate::Create() {
+  views::ViewsDelegate::views_delegate = new AthenaViewsDelegateImpl;
+  return views::ViewsDelegate::views_delegate;
 }
 
-views::NonClientFrameView* AthenaViewsDelegate::CreateDefaultNonClientFrameView(
-    views::Widget* widget) {
-  return new AthenaFrameView(widget);
+// static
+void AthenaViewsDelegate::Shutdown() {
+  CHECK(views::ViewsDelegate::views_delegate);
+  delete views::ViewsDelegate::views_delegate;
+  views::ViewsDelegate::views_delegate = NULL;
 }
 
 }  // namespace athena