Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 597533002: Add, test, and use clock utilities (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add, test, and use clock utilities. This includes ClockMonotonicNanoseconds() and SleepNanoseconds(). SleepNanoseconds() is like base::PlatformThread::Sleep(), but PlatformThread is not in mini_chromium and I’m not keen on adding it because I’m not sold on the interface. I’m not convinced Sleep() belongs there, and I don’t want to have to bring all of base::Time* along for the ride. TEST=util_test Clock.*:MachMessageServer.*:ServiceManagement.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8decf86db833551f996760772c222ce8feafa9e4

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : (no change) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -42 lines) Patch
M util/mac/service_management.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M util/mac/service_management_test.mm View 5 chunks +4 lines, -13 lines 0 comments Download
M util/mach/mach_message_server.cc View 3 chunks +4 lines, -24 lines 0 comments Download
A util/misc/clock.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A util/misc/clock.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
A util/misc/clock_mac.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A util/misc/clock_test.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M util/util.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-23 14:01:03 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-24 17:55:14 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-24 18:08:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 8decf86db833 (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698