Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 59753008: Quota: Add proxy for QuotaManager::GetUsageAndQuota (Closed)

Created:
7 years, 1 month ago by nhiroki
Modified:
7 years, 1 month ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Quota: Add proxy for QuotaManager::GetUsageAndQuota This introduces proxy implementation for QuotaManager::GetUsageAndQuota in QuotaManagerProxy. The proxy will be used from QuotaBackend living on the File thread so that the backend can make sure of available quota space before reserving quota. BUG=303443 TEST=n/a NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233254

Patch Set 1 : #

Total comments: 4

Patch Set 2 : SingleThreadTaskRunner -> SequencedTaskRunner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M webkit/browser/appcache/appcache_host_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/browser/appcache/appcache_storage_impl_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/browser/quota/mock_quota_manager.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/browser/quota/quota_manager.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M webkit/browser/quota/quota_manager.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nhiroki
ptal https://codereview.chromium.org/59753008/diff/30001/webkit/browser/quota/mock_quota_manager.h File webkit/browser/quota/mock_quota_manager.h (right): https://codereview.chromium.org/59753008/diff/30001/webkit/browser/quota/mock_quota_manager.h#newcode165 webkit/browser/quota/mock_quota_manager.h:165: // id SetUsageCacheEnabled() Will be removed.
7 years, 1 month ago (2013-11-06 06:02:16 UTC) #1
kinuko
https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc File webkit/browser/appcache/appcache_storage_impl_unittest.cc (right): https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc#newcode329 webkit/browser/appcache/appcache_storage_impl_unittest.cc:329: base::SingleThreadTaskRunner* original_task_runner, Is this going to be always single-threaded? ...
7 years, 1 month ago (2013-11-06 06:07:26 UTC) #2
tzik
Looks good https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc File webkit/browser/appcache/appcache_storage_impl_unittest.cc (right): https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc#newcode329 webkit/browser/appcache/appcache_storage_impl_unittest.cc:329: base::SingleThreadTaskRunner* original_task_runner, Can we use SequencedTaskRunner instead ...
7 years, 1 month ago (2013-11-06 06:10:43 UTC) #3
nhiroki
Thanks! Update. https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc File webkit/browser/appcache/appcache_storage_impl_unittest.cc (right): https://codereview.chromium.org/59753008/diff/30001/webkit/browser/appcache/appcache_storage_impl_unittest.cc#newcode329 webkit/browser/appcache/appcache_storage_impl_unittest.cc:329: base::SingleThreadTaskRunner* original_task_runner, On 2013/11/06 06:10:43, tzik wrote: ...
7 years, 1 month ago (2013-11-06 06:20:16 UTC) #4
tzik
lgtm
7 years, 1 month ago (2013-11-06 06:25:41 UTC) #5
kinuko
lgtm2 2013/11/06 15:25 <tzik@chromium.org>: > lgtm > > > > https://codereview.chromium.org/59753008/ > To unsubscribe from ...
7 years, 1 month ago (2013-11-06 06:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/59753008/140001
7 years, 1 month ago (2013-11-06 06:47:02 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94693
7 years, 1 month ago (2013-11-06 10:23:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/59753008/140001
7 years, 1 month ago (2013-11-06 10:31:13 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 10:33:06 UTC) #10
Message was sent while issue was closed.
Change committed as 233254

Powered by Google App Engine
This is Rietveld 408576698