Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
59753003:
Don't stop because we couldn't restart usb devices. (Closed)
|
Created:
7 years, 1 month ago by ian_cottrell Modified:
6 years, 11 months ago CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, rmcilroy Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionDon't stop because we couldn't restart usb devices.
One of the build bots was failing to restart one device, but it still had four other devices online it could continue with.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243292
Patch Set 1 #
Total comments: 1
Messages
Total messages: 10 (0 generated)
drive-by since I'm not an owners in buildbot.. https://codereview.chromium.org/59753003/diff/1/build/android/buildbot/bb_dev... File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/59753003/diff/1/build/android/buildbot/bb_dev... build/android/buildbot/bb_device_status_check.py:298: print "USB reset stage failed, continuing anyway." nit: I think the PrintWarning() needs to come after the message, and it should be single quotes for print.. there was some debate about this return code when it was added, not quite sure what was the motiviation, but I think your patch is a good thing, there's no reason not to keep trying, this restart_usb unfortunately is not as deterministic as it should've been..
> there was some debate about this return code when it was added, not quite sure > what was the motiviation, but I think your patch is a good thing, there's no > reason not to keep trying, this restart_usb unfortunately is not as > deterministic as it should've been.. I agree that this should not cause the bot to fail. I argued for this originally. Can you provide more information about where this was failing? What bot/builds? It is worth investigating why restart_usb was failing.
I could not work out why the reset is failing, I think that might take somebody closer to the machine with a better understanding of what reset does. Links to the failing run that caused me to think this change is necessary: The step was this one https://chromegw.corp.google.com/i/clank/builders/nakasi-sharded-official-per... The output looked like this @@@BUILD_STEP device_status_check@@@ > build/android/buildbot/bb_device_status_check.py --restart-usb kill 15 18618 (adb [adb fork-server server]) kill 15 18656 (adb []) kill 15 18657 (adb []) kill 3 18656 (adb []) kill 3 18657 (adb []) kill 9 18656 (adb []) kill 9 18657 (adb []) Unable to kill 18656 (adb []) Unable to kill 18657 (adb []) > lsusb > /usr/bin/restart_usb 003 105 < /usr/bin/restart_usb 003 105 Restarted USB device /dev/bus/usb/003/105 > /usr/bin/restart_usb 003 026 < /usr/bin/restart_usb 003 026 Restarted USB device /dev/bus/usb/003/026 > /usr/bin/restart_usb 002 002 < /usr/bin/restart_usb 002 002 Restarted USB device /dev/bus/usb/002/002 > /usr/bin/restart_usb 001 026 < /usr/bin/restart_usb 001 026 ERROR: process exited with code 255 @@@STEP_FAILURE@@@ Error restarting USB device /dev/bus/usb/001/026 > /usr/bin/restart_usb 001 002 < /usr/bin/restart_usb 001 002 Restarted USB device /dev/bus/usb/001/002 < build/android/buildbot/bb_device_status_check.py --restart-usb ERROR: process exited with code 1 @@@STEP_FAILURE@@@ FATAL 1 != 88
On 2013/11/06 11:23:32, ian_cottrell wrote: > I could not work out why the reset is failing, I think that might take somebody > closer to the machine with a better understanding of what reset does. > > Links to the failing run that caused me to think this change is necessary: > The step was this one > https://chromegw.corp.google.com/i/clank/builders/nakasi-sharded-official-per... > > The output looked like this > > @@@BUILD_STEP device_status_check@@@ > > build/android/buildbot/bb_device_status_check.py --restart-usb > kill 15 18618 (adb [adb fork-server server]) > kill 15 18656 (adb []) > kill 15 18657 (adb []) > kill 3 18656 (adb []) > kill 3 18657 (adb []) > kill 9 18656 (adb []) > kill 9 18657 (adb []) > Unable to kill 18656 (adb []) > Unable to kill 18657 (adb []) > > lsusb > > /usr/bin/restart_usb 003 105 > < /usr/bin/restart_usb 003 105 > Restarted USB device /dev/bus/usb/003/105 > > /usr/bin/restart_usb 003 026 > < /usr/bin/restart_usb 003 026 > Restarted USB device /dev/bus/usb/003/026 > > /usr/bin/restart_usb 002 002 > < /usr/bin/restart_usb 002 002 > Restarted USB device /dev/bus/usb/002/002 > > /usr/bin/restart_usb 001 026 > < /usr/bin/restart_usb 001 026 > ERROR: process exited with code 255 > @@@STEP_FAILURE@@@ > Error restarting USB device /dev/bus/usb/001/026 > > /usr/bin/restart_usb 001 002 > < /usr/bin/restart_usb 001 002 > Restarted USB device /dev/bus/usb/001/002 > < build/android/buildbot/bb_device_status_check.py --restart-usb > ERROR: process exited with code 1 > @@@STEP_FAILURE@@@ > FATAL 1 != 88 This error is still happening, any chance of getting this committed.
On 2014/01/06 12:37:49, Anton wrote: > On 2013/11/06 11:23:32, ian_cottrell wrote: > > I could not work out why the reset is failing, I think that might take > somebody > > closer to the machine with a better understanding of what reset does. > > > > Links to the failing run that caused me to think this change is necessary: > > The step was this one > > > https://chromegw.corp.google.com/i/clank/builders/nakasi-sharded-official-per... > > > > The output looked like this > > > > @@@BUILD_STEP device_status_check@@@ > > > build/android/buildbot/bb_device_status_check.py --restart-usb > > kill 15 18618 (adb [adb fork-server server]) > > kill 15 18656 (adb []) > > kill 15 18657 (adb []) > > kill 3 18656 (adb []) > > kill 3 18657 (adb []) > > kill 9 18656 (adb []) > > kill 9 18657 (adb []) > > Unable to kill 18656 (adb []) > > Unable to kill 18657 (adb []) > > > lsusb > > > /usr/bin/restart_usb 003 105 > > < /usr/bin/restart_usb 003 105 > > Restarted USB device /dev/bus/usb/003/105 > > > /usr/bin/restart_usb 003 026 > > < /usr/bin/restart_usb 003 026 > > Restarted USB device /dev/bus/usb/003/026 > > > /usr/bin/restart_usb 002 002 > > < /usr/bin/restart_usb 002 002 > > Restarted USB device /dev/bus/usb/002/002 > > > /usr/bin/restart_usb 001 026 > > < /usr/bin/restart_usb 001 026 > > ERROR: process exited with code 255 > > @@@STEP_FAILURE@@@ > > Error restarting USB device /dev/bus/usb/001/026 > > > /usr/bin/restart_usb 001 002 > > < /usr/bin/restart_usb 001 002 > > Restarted USB device /dev/bus/usb/001/002 > > < build/android/buildbot/bb_device_status_check.py --restart-usb > > ERROR: process exited with code 1 > > @@@STEP_FAILURE@@@ > > FATAL 1 != 88 > > This error is still happening, any chance of getting this committed. yes. lgtm.
On 2014/01/06 19:29:40, navabi wrote: > On 2014/01/06 12:37:49, Anton wrote: > > On 2013/11/06 11:23:32, ian_cottrell wrote: > > > I could not work out why the reset is failing, I think that might take > > somebody > > > closer to the machine with a better understanding of what reset does. > > > > > > Links to the failing run that caused me to think this change is necessary: > > > The step was this one > > > > > > https://chromegw.corp.google.com/i/clank/builders/nakasi-sharded-official-per... > > > > > > The output looked like this > > > > > > @@@BUILD_STEP device_status_check@@@ > > > > build/android/buildbot/bb_device_status_check.py --restart-usb > > > kill 15 18618 (adb [adb fork-server server]) > > > kill 15 18656 (adb []) > > > kill 15 18657 (adb []) > > > kill 3 18656 (adb []) > > > kill 3 18657 (adb []) > > > kill 9 18656 (adb []) > > > kill 9 18657 (adb []) > > > Unable to kill 18656 (adb []) > > > Unable to kill 18657 (adb []) > > > > lsusb > > > > /usr/bin/restart_usb 003 105 > > > < /usr/bin/restart_usb 003 105 > > > Restarted USB device /dev/bus/usb/003/105 > > > > /usr/bin/restart_usb 003 026 > > > < /usr/bin/restart_usb 003 026 > > > Restarted USB device /dev/bus/usb/003/026 > > > > /usr/bin/restart_usb 002 002 > > > < /usr/bin/restart_usb 002 002 > > > Restarted USB device /dev/bus/usb/002/002 > > > > /usr/bin/restart_usb 001 026 > > > < /usr/bin/restart_usb 001 026 > > > ERROR: process exited with code 255 > > > @@@STEP_FAILURE@@@ > > > Error restarting USB device /dev/bus/usb/001/026 > > > > /usr/bin/restart_usb 001 002 > > > < /usr/bin/restart_usb 001 002 > > > Restarted USB device /dev/bus/usb/001/002 > > > < build/android/buildbot/bb_device_status_check.py --restart-usb > > > ERROR: process exited with code 1 > > > @@@STEP_FAILURE@@@ > > > FATAL 1 != 88 > > > > This error is still happening, any chance of getting this committed. > > yes. lgtm. lgtm (from my chromium.org account).
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/59753003/1
Message was sent while issue was closed.
Change committed as 243292 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
