Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 597523002: Fix crash on login screen for Athena Chrome (Closed)

Created:
6 years, 3 months ago by Dmitry Polukhin
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash on login screen for Athena Chrome BUG=none TEST=manual Committed: https://crrev.com/065f4a555c71b6ab2ef41cd5d6663b99aab1e805 Cr-Commit-Position: refs/heads/master@{#296170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Polukhin
PTAL
6 years, 3 months ago (2014-09-23 10:46:59 UTC) #2
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-23 11:48:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597523002/1
6 years, 3 months ago (2014-09-23 11:49:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 03e7cee2137a2835d91631e42695c9b5ac0f7616
6 years, 3 months ago (2014-09-23 12:51:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 12:51:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/065f4a555c71b6ab2ef41cd5d6663b99aab1e805
Cr-Commit-Position: refs/heads/master@{#296170}

Powered by Google App Engine
This is Rietveld 408576698