Sync current wallpaper

chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var WALLPAPER_PICKER_WIDTH = 574;
 var WALLPAPER_PICKER_HEIGHT = 420;
 
 var wallpaperPickerWindow;
 
 var surpriseWallpaper = null;
@@ skipping 217 matching lines @@
     alphaEnabled: true
   }, function(w) {
     wallpaperPickerWindow = w;
     chrome.wallpaperPrivate.minimizeInactiveWindows();
     w.onClosed.addListener(function() {
       chrome.wallpaperPrivate.restoreMinimizedWindows();
     });
   });
 });
 
+enableSync(
+  function() {
+    chrome.syncFileSystem.onFileStatusChanged.addListener(function(detail) {
+      Constants.WallpaperLocalStorage.get(Constants.AccessLocalWallpaperInfoKey,
+        function(items) {
+          var localData = items[Constants.AccessLocalWallpaperInfoKey];
+          if (localData &&
+              localData.source == Constants.WallpaperSourceEnum.Custom)
+            setWallpaperByName(localData.url, localData.layout);

[bshe, 2014/09/24 17:07:05]

I think we should only set wallpaper if

detail.status == 'synced' && detail.action == 'added' && detail.direction ==
'remote_to_local' &&
localData.source == Constants.WallpaperSourceEnum.Custom &&
localData.url == detail.fileEntry.file().name

[Ran, 2014/09/26 17:34:53]

Done.

+       });
+  });
+});
+
+var globalSyncFs;
 chrome.storage.onChanged.addListener(function(changes, namespace) {
+  enableSync(function() {
+    //active syncFileSystem
+    chrome.syncFileSystem.requestFileSystem(function(fs) {globalSyncFs = fs;});

[bshe, 2014/09/24 17:07:05]

We dont want to requestFileSystem each time storage changed. Move it outside of
this function.

[Ran, 2014/09/26 17:34:53]

Done.

+  });
   if (changes[Constants.AccessSurpriseMeEnabledKey]) {
     if (changes[Constants.AccessSurpriseMeEnabledKey].newValue) {
       SurpriseWallpaper.getInstance().next();
     } else {
       SurpriseWallpaper.getInstance().disable();
     }
   }
 
   if (changes[Constants.AccessSyncWallpaperInfoKey]) {
     var newValue = changes[Constants.AccessSyncWallpaperInfoKey].newValue;
     Constants.WallpaperLocalStorage.get(Constants.AccessLocalWallpaperInfoKey,
                                         function(items) {
       // Normally, the wallpaper info saved in local storage and sync storage
       // are the same. If the synced value changed by sync service, they may
       // different. In that case, change wallpaper to the one saved in sync
       // storage and update the local value.
       var localValue = items[Constants.AccessLocalWallpaperInfoKey];
       if (localValue == undefined ||
           localValue.url != newValue.url ||
           localValue.layout != newValue.layout ||
           localValue.source != newValue.source) {
         if (newValue.source == Constants.WallpaperSourceEnum.Online) {
           // TODO(bshe): Consider schedule an alarm to set online wallpaper
           // later when failed. Note that we need to cancel the retry if user
           // set another wallpaper before retry alarm invoked.
           WallpaperUtil.setOnlineWallpaper(newValue.url, newValue.layout,
             function() {}, function() {});
         }
+        if (newValue.source == Constants.WallpaperSourceEnum.Custom) {

[bshe, 2014/09/24 17:07:05]

nit: use "else if" and move this line to previous line. e.g
 } else if (newValue.....) {

[Ran, 2014/09/26 17:34:53]

Done.

+          setWallpaperByName(newValue.url, newValue.layout);
+        }
         WallpaperUtil.saveToStorage(Constants.AccessLocalWallpaperInfoKey,
                                     newValue, false);
       }
     });
   }
 });
 
 chrome.alarms.onAlarm.addListener(function() {
   SurpriseWallpaper.getInstance().next();
 });