Issue 597413004: Instrumenting URLMatcher matchers rebuilding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597413004: Instrumenting URLMatcher matchers rebuilding (Closed)

Created:
6 years, 2 months ago by vadimt

Modified:
6 years, 2 months ago

Reviewers:
battre

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of rebuilding matchers. BUG=417106 Committed: https://crrev.com/9aa4f709a65b691fa70b1a129b2d7fa1330c84b4 Cr-Commit-Position: refs/heads/master@{#296945}

Patch Set 1 #

Patch Set 2 : Rebasing #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	components/url_matcher/url_matcher.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597413004/20001

6 years, 2 months ago (2014-09-26 14:21:52 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 8a10d95d7f4b9ca6c44a81823a00e220df8f50bd

6 years, 2 months ago (2014-09-26 15:32:24 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 15:33:03 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/9aa4f709a65b691fa70b1a129b2d7fa1330c84b4
Cr-Commit-Position: refs/heads/master@{#296945}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages