mojo/system/dispatcher_unittest.cc - Issue 597413002: Mojo: NULL -> nullptr in mojo/system and mojo/embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/system/dispatcher_unittest.cc

Issue 597413002: Mojo: NULL -> nullptr in mojo/system and mojo/embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/system/dispatcher_unittest.cc

diff --git a/mojo/system/dispatcher_unittest.cc b/mojo/system/dispatcher_unittest.cc

index 1a7bba5759fca9bfc61f5ac4465276b76ed4aeca..3cce26327ced9dc61d48a84f49c323684e80e482 100644

--- a/mojo/system/dispatcher_unittest.cc

+++ b/mojo/system/dispatcher_unittest.cc

@@ -45,12 +45,12 @@ TEST(DispatcherTest, Basic) {

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,

d->WriteMessage(

- NullUserPointer(), 0, NULL, MOJO_WRITE_MESSAGE_FLAG_NONE));

+ NullUserPointer(), 0, nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,

d->ReadMessage(NullUserPointer(),

NullUserPointer(),

- NULL,

+ nullptr,

MOJO_WRITE_MESSAGE_FLAG_NONE));

EXPECT_EQ(

MOJO_RESULT_INVALID_ARGUMENT,

@@ -91,12 +91,12 @@ TEST(DispatcherTest, Basic) {

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,

d->WriteMessage(

- NullUserPointer(), 0, NULL, MOJO_WRITE_MESSAGE_FLAG_NONE));

+ NullUserPointer(), 0, nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,

d->ReadMessage(NullUserPointer(),

NullUserPointer(),

- NULL,

+ nullptr,

MOJO_WRITE_MESSAGE_FLAG_NONE));

EXPECT_EQ(

MOJO_RESULT_INVALID_ARGUMENT,

@@ -175,14 +175,14 @@ class ThreadSafetyStressThread : public base::SimpleThread {

EXPECT_EQ(

MOJO_RESULT_INVALID_ARGUMENT,

dispatcher_->WriteMessage(

- NullUserPointer(), 0, NULL, MOJO_WRITE_MESSAGE_FLAG_NONE));

+ NullUserPointer(), 0, nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));

break;

case READ_MESSAGE:

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,

dispatcher_->ReadMessage(NullUserPointer(),

NullUserPointer(),

- NULL,

+ nullptr,

MOJO_WRITE_MESSAGE_FLAG_NONE));

break;

case WRITE_DATA:

« mojo/embedder/embedder_unittest.cc ('K') | « mojo/system/dispatcher.cc ('k') | mojo/system/entrypoints.cc » ('j') | mojo/system/local_data_pipe_unittest.cc » ('J')