Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 597413002: Mojo: NULL -> nullptr in mojo/system and mojo/embedder. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: NULL -> nullptr in mojo/system and mojo/embedder. R=jamesr@chromium.org Committed: https://crrev.com/f538bf10cbad94f7a63c5b6cbaaed61e7ff698db Cr-Commit-Position: refs/heads/master@{#296560}

Patch Set 1 #

Total comments: 4

Patch Set 2 : EXPECT_TRUE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -413 lines) Patch
M mojo/embedder/channel_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/embedder_unittest.cc View 1 24 chunks +54 lines, -42 lines 0 comments Download
M mojo/embedder/platform_channel_pair_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/platform_channel_pair_win.cc View 2 chunks +20 lines, -19 lines 0 comments Download
M mojo/embedder/simple_platform_shared_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/channel_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/system/core.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/core_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/data_pipe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/dispatcher_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/system/entrypoints.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/handle_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 1 44 chunks +83 lines, -83 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/memory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/memory_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/message_in_transit.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/message_pipe_dispatcher_unittest.cc View 18 chunks +28 lines, -27 lines 0 comments Download
M mojo/system/message_pipe_perftest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/message_pipe_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/message_pipe_unittest.cc View 38 chunks +39 lines, -39 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 13 chunks +18 lines, -18 lines 0 comments Download
M mojo/system/platform_handle_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/raw_channel_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 30 chunks +86 lines, -76 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M mojo/system/transport_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-24 21:33:57 UTC) #1
jamesr
lgtm https://codereview.chromium.org/597413002/diff/1/mojo/embedder/embedder_unittest.cc File mojo/embedder/embedder_unittest.cc (right): https://codereview.chromium.org/597413002/diff/1/mojo/embedder/embedder_unittest.cc#newcode167 mojo/embedder/embedder_unittest.cc:167: EXPECT_TRUE(client_channel.channel_info() != nullptr); why not just EXPECT_TRUE(client_channel.channel_info()); ? ...
6 years, 2 months ago (2014-09-24 22:03:01 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/597413002/diff/1/mojo/embedder/embedder_unittest.cc File mojo/embedder/embedder_unittest.cc (right): https://codereview.chromium.org/597413002/diff/1/mojo/embedder/embedder_unittest.cc#newcode167 mojo/embedder/embedder_unittest.cc:167: EXPECT_TRUE(client_channel.channel_info() != nullptr); On 2014/09/24 22:03:00, jamesr wrote: ...
6 years, 2 months ago (2014-09-24 22:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597413002/20001
6 years, 2 months ago (2014-09-24 22:11:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0bee91e0bd211fa3be53d8689aaab8dc6530ae1f
6 years, 2 months ago (2014-09-24 23:33:01 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 23:46:57 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f538bf10cbad94f7a63c5b6cbaaed61e7ff698db
Cr-Commit-Position: refs/heads/master@{#296560}

Powered by Google App Engine
This is Rietveld 408576698